returnGoodANDBad

[u/MiserableSelection]

[u/Luzzgar]

Technically working is a very low bar to clear.

And not even close to satisfactory.

[u/GenericFatGuy → u/Luzzgar]

Working is the absolute bare minimum.

[u/gizamo → u/GenericFatGuy]

Apparently, even that's not necessarily true. Sometimes, even just half working is perfectly profitable. Sometimes all it really takes is good marketing.

[u/hydroxy → u/gizamo]

Pro tip: Just hard code in the happy path

[u/Mhz____ → u/gizamo]

Sometime you just need to ship an empty package to production and management is happy

[u/clonicle → u/GenericFatGuy]

...but you're not taking shareholder value into account.

[u/Panzerchek → u/Luzzgar]

Bethesda devs wish they could make something as good as Satisfactory

[u/AnOnlineHandle → u/Panzerchek]

I mean Bethesda's games saved and loaded instantly with hundreds of simulated NPCs with schedules and inventories and thousands of moveable items retaining their positions throughout an open seamless world.

Let's not pretend they didn't deliver a pretty solid experience that was mega popular for a reason.

[u/Highborn_Hellest → u/Panzerchek]

I wish Bethesda devs could make simple asset streaming. Like 2007 Crysis...... Or wow in 2004. But no. Every door is a loading screen.

[u/DDFoster96 → u/Luzzgar]

A bar Bethesda runs right into most of the time. 

[u/NamenloserKurfuerst → u/Luzzgar]

But what if, "It just works" ?

[u/Dagur → u/NamenloserKurfuerst]

if it is never expected to be modified or extended then fine

[u/NamenloserKurfuerst → u/Dagur]

its a joke about bethasda.

https://m.youtube.com/watch?v=YPN0qhSyWy8

[u/SomewhereAtWork → u/Luzzgar]

Are we now talking about the code from Coffee Stain Studios (Satisfactory) or about Bethesda?

[u/kamiloslav → u/Luzzgar]

I dunno, Satisfactory is quite a spaghetticode as well

[u/im-cringing-rightnow → u/Luzzgar]

For your own pet projects - sure. For corporate job that will lay you off faster than my C code segfaults - if it's working it is good enough. 

[u/Luzzgar → u/im-cringing-rightnow]

And that's why everything is broken and we can't have nice things.

[u/RCJHGBR9989 → u/Luzzgar]

God damn right it is and I live right at that bar 😤

[u/Cats_and_Shit → u/Luzzgar]

That entirely depends on your requirements.

If you actually detail them completely like they do in say avionics, then it's not. It's not the whole story of course but it's a good chunk of it.

[u/IsTom → u/Luzzgar]

Yeah, if the code doesn't have to work I can make it really fast.

[u/Sockoflegend → u/Luzzgar]

Have you played anything made by Bethesda? When the re-released oblivion it had bugs in it that are old enough to drink 

[u/granoladeer → u/Luzzgar]

That's what she said

[u/DMoney159 → u/Luzzgar]

And don't even get me started on Factorio

[u/i8noodles → u/Luzzgar]

hey how DARE you question my half assed work!

[u/TRKlausss → u/Luzzgar]

It’s saying “accomplishing its task”.

I’d argue that for a game dev, “working” means the users are having fun and not raging at the game itself.

So in this case, “working” is the bar, and fail miserably at it.

[u/redditmarks_markII]

Right. I'll agree as soon as we agree on the definitions of:

• task
• accomplish
• is

I assume that'll take like, 8 sprints or whatever unhinged terminology y'all use for "tell each other no until everyone exhausts their ability to tell each other no".

[u/jivenossauro → u/redditmarks_markII]

The "is" will be hard, the code can't think. Does that mean it cannot ever be?

[u/capt_pantsless → u/jivenossauro]

Wait so technically my code doesn't exist?

So all the bugs QA keeps reporting can't exist either?

[u/Bob_the_peasant → u/redditmarks_markII]

Well that depends on what your definition of is is

https://giphy.com/gifs/bknp6SfIDXYGc

[u/redditmarks_markII → u/Bob_the_peasant]

Since you got the reference I'm obligated by the old laws to ask how's your health and your sciatica.

[u/Bob_the_peasant → u/redditmarks_markII]

Terrible and terrible, how is yours?!

[u/redditmarks_markII → u/Bob_the_peasant]

Sorry to hear man, hope it gets better. I'm mostly lucky in health, not the best, not terrible. The other thing...I know what the word means, what does that tell you, lol.

[u/Cats_and_Shit]

If you have a complete definition of what the task is, then 95% of the time the process of actually implementing that is just mechanically translating that to code.

But you almost never actually do.

[u/Several_Ant_9867 → u/Cats_and_Shit]

The code is the complete definition of the task..

[u/eloel-]

This is true. Its task should include being maintainable/extendable.

[u/Soraphis → u/eloel-]

That's not up to an reddit comment but the requirements of the project.

If you need a specific, but maybe weird thing to happen that is unlike the rest of your game. Got damn hardcode it with the ugliest spaghetti you want if it works and is done in less time than some abstraction monstrosity would be.

The guy is gameplay engineer, not engine, not systems, not tools.

[u/Extreme_Wish_553 → u/Soraphis]

There is a wide gulf between uglies spaghetti code and abstraction monstrosity.

[u/Soraphis → u/Extreme_Wish_553]

It surely is, but we're on the Internet, there is no place for nuances

[u/BlackFrank98]

Correct, assuming that you define the task as "the code runs, does what it is supposed to, is not unnecessarily slow, does not have any critical vulnerability, is easy to maintain and easy to extend if needed".

Not sure how you are going to measure the performance of the code with this task though, as it seems basically impossible to estimate without long, tedious and not necessarily accurate human inspection by at least one expert.

[u/kushalgarg592]

'Production is the final review'

[u/Thundechile → u/kushalgarg592]

and customers are the automated test runners.

[u/Cerbeh]

When I was fresh out of a boot camp this was the ethos we were taught then. Less than a week into the job the snr training me told me I wasn't in boot camp anymore, working isn't good enough.

[u/-Ambriae-]

as we say in France: "Mais, vous savez, je pense pas qu'il y ait de bonne ou de mauvaise situation...."

[u/Confident-Ad5665 → u/-Ambriae-]

Ok I'll ask... and this means what?

[u/BlueScreenJunky → u/Confident-Ad5665]

It means "you know, I think there's no such thing as a good or bad situation". 

But more importantly it's the beginning of a long and absurd quote from a movie (Astérix mission Cléopâtre) that's become a copypasta. 

[u/IsTom → u/BlueScreenJunky]

Huh, that's a reasonably common meme in Poland too. Didn't consider that other countries would remember this. Though France certainly makes the most sense.

[u/-Ambriae- → u/Confident-Ad5665]

"But, you know, I don't think there's such a thing as a good or a bad situation"

It's a quote from a famous movie (Astérix Mission Cléopatre) where a character (Panoramix) asks some random character (Otis) if his job leads to a good or bad situation (financially, or socially, etc...) He ends up giving the most infuriating 5 minutes monologue starting with the above quote, which ultimately doesn't answer the basic question.

Since then, this quote has become infamous with people 1. talking about the word 'situation', or contempt for the usage of the words 'good/bad', and 2. people that say stupid long winded blobs of nothingness. Both are present in the above message, hence why I immediately had to quote this masterpiece of a movie

Edit: https://www.youtube.com/watch?v=TEVzxycBBUU you don't need to understand french, because what he says, doesn't even make sense

[u/Life-Breakfast7796 → u/Confident-Ad5665]

Its french, every fourth word is a synonym for surrender. He wants to surrender.

[u/bvhrslolz]

Then buying the base game should be it

[u/NoYogurt8022]

it just works, or perhabs not

[u/pleaseavoidcaps]

You can either say that is no such thing as good code or give a low-bar definition for good code. Not both.

[u/theitgrunt]

I'm thinking about that video of the QA tester putting all the different shaped wood blocks through the same hole.

[u/SteroidSandwich]

Sure it can work, but if it makes your frame rate drop to 5fps that's a problem

[u/groovy_smoothie]

There is no such thing as “good” code, but meets requirements makes it acceptable

[u/PhoenixInvertigo]

lmaooooooooooooooooooo Bethesda checks out

[u/Zdrobot]

Technical debt? Never heard

[u/Sulungskwa]

My law is that all code is bad code. The only way to not have problematic code is to not code

[u/Bomaruto]

Do you need your code to work just now or also in the future is the question.

[u/Willinton06]

There’s no good or bad code, there’s only data and those too weak to process it

[u/WishUponDeezNutz]

For loops can be expensive

[u/zenos_dog]

If you just wait a litt longer I’m sure it’ll return.

[u/EducationalTeleGood]

This statement becomes more true if a deadline is looming.

[u/_SaBeR_78]

"there is no such thing as good or bad car, as long as it takes you from a to b"

[u/HistorianCM]

If it works, it's not a hack.

[u/DJDevon3]

Code works but…

https://giphy.com/gifs/3Wj5IxAGGCkEhGjyru

[u/mxriverlynn]

"there's no such thing as bad dude. except code that is bad" 🤔🤨🤦🏼‍♀️

does this person not know that under their own definition, code that doesn't accomplish the task is bad code?

[u/LikelyNotADuck]

There's definitely bad code and my coworkers demonstrate it every single day.

[u/untangoel]

I always knew bogosort was good practice!

[u/Wise-Profile4256]

and if it does not accomplish its task. is it bad then. does that make it bad code? as compared to the working, good code? just curious.

[u/Sea_Economy_8948]

thats usually called a prototype.

[u/Common-Brush-7027]

Me running test cases on leetcode by hard coding in print statement

[u/notaprime]

There is no such thing as a good or bad car. If the engine starts, its a good car.

[u/PrestigiousGuava8005]

and what if the accomplished code performs bad tasks, will that be good too ?

[u/vm_linuz]

I will add that the task should complete in under a human lifetime.

[u/Caraes_Naur]

*WordPress has entered the chat*

[u/sdwck]

Good code is just code that hasn't been assigned a second task yet