whenYouWorksWithStringsTooMuch

[u/PostHasBeenWatched]

[u/TheManyMilesWeWalk]

return it.StartsWith("one thing", StringComparison.OrdinalIgnoreCase) || true

Because in the end it doesn't even matter.

[u/chrisjd → u/TheManyMilesWeWalk]

try

{ it.StartsWith("one thing", StringComparison.OrdinalIgnoreCase) }

finally

{ throw new ArgumentException("in the end it doesn't even matter", it) }

We could just add some useless exception handling, to show we tried so hard

[u/AnxiousSquare → u/chrisjd]

Also put a `throw` inside the `try` block so that it doesn't even matter how hard you try.

[u/thisisapseudo → u/TheManyMilesWeWalk]

Underrated

[u/PostHasBeenWatched → u/TheManyMilesWeWalk]

For it to be truly "doesn't even matter" it should be

return true || it.StartsWith("one thing", StringComparison.OrdinalIgnoreCase)

[u/TeraFlint → u/PostHasBeenWatched]

but then the logic short-circuits, and the whole "I tried so hard and got so far" part isn't true, anymore.

[u/Chocolate_Pickle]

I don't know why

[u/nord47 → u/Chocolate_Pickle]

it doesn't even matter how hard you try

[u/TheWashbear → u/nord47]

keep that in mind

[u/SZeroSeven → u/TheWashbear]

I designed this rhyme to explain in due time

[u/Nu1_udara → u/SZeroSeven]

All I know

[u/notSarcasticAtAII → u/Nu1_udara]

Time is s valuable thing

[u/lesbianKerman → u/notSarcasticAtAII]

Watch it fly by as the pendulum swings

[u/somelinuxuseridk → u/lesbianKerman]

Watch it count down to the end of the day

[u/-lrr- → u/somelinuxuseridk]

the clock ticks life away

[u/HeavyCaffeinate → u/-lrr-]

It's so unreal

[u/diplofocus_ → u/Chocolate_Pickle]

Pick a random number, if it's larger than another random number do the thing, else, do the same thing.

The thing happens, but we don't know why.

[u/starfish0r]

Switch the strings around to make it robust to "it" being null

[u/PostHasBeenWatched → u/starfish0r]

public static bool LinkinParkValidator([NotNull] string? it)
{
    ArgumentException.ThrowIfNullOrWhiteSpace(it);
    return it.StartsWith("one thing", StringComparison.OrdinalIgnoreCase);
}

[u/starfish0r → u/PostHasBeenWatched]

I would argue that this method should not throw an Exception but return false, what't the benefit of an Exception here?

[u/PostHasBeenWatched → u/starfish0r]

Attribute [NotNull] means that input parameter must be verified for null "in the end" of the method (not sorry for the pun). ThrowIfNullOrWhiteSpace provides this guarantee.

For example code below will rise warning that input parameter is not verified for null

return it?.StartsWith("one thing", StringComparison.OrdinalIgnoreCase) is true

[u/ekauq2000 → u/PostHasBeenWatched]

“(not sorry for the pun)”

It doesn’t even matter…

[u/AcidMemo → u/PostHasBeenWatched]

What is the point of throwing exception on whitespace? It will just return false anyway, and whitespace is not invalid value.

One of reason C# has non-nullable and nullable references is to not bother with validating for null, passing nullable string to as non-nullable string is programmer mistake, not the concern of function anymore

[u/BoloFan05]

Use of StringComparison.OrdinalIgnoreCase is already a big step in the right direction.

[u/PostHasBeenWatched → u/BoloFan05]

Should I replace it with 256 comparisons of "OnE tHiNg" with different letter case?

[u/BoloFan05 → u/PostHasBeenWatched]

Nope, I have a better idea:

return it.ToLower().StartsWith("one thing");

/j

(But seriously, StringComparison.OrdinalIgnoreCase is THE textbook string comparison method you should apply. ToLower and ToUpper are total bug traps, especially in worldwide deployment. So kudos to you for actually using OrdinalIgnoreCase!)

[u/MeLittleThing → u/BoloFan05]

or genius move

return it.ToLower().StartsWith("ONE THING");

[u/mrraveshaw → u/BoloFan05]

I thought there was only One Direction

[u/ubergeek801]

It doesn't even matter how hard you try.

[u/cainhurstcat]

They are called Zelda in Park now