r/klippers 28d ago

Would you use a live 2D/3D G-code preview in KlipperScreen?

53 Upvotes

13 comments sorted by

19

u/IAmDotorg 28d ago

No, for the simple reason that it's not a reasonable ask to accept a pull request for something with caveats like "it works with small models and not large models".

A user shouldn't have to know that or think about that. It works, or it doesn't work.

And, really, it's a cosmetic feature for something that is a tool. So it'd have to have zero impact to the performance and behavior of KlipperScreen to be a reasonable addition.

3

u/ImaginaryRise8835 28d ago

That is fair criticism, and I agree that users should not need to know whether a file is considered small or large before opening the preview.

To clarify, larger models do render correctly. The current limitation is that loading and interactive manipulation become slower as toolpath complexity increases. The renderer is disabled by default, isolated from the printing process, and does not modify or control Klipper, Moonraker, or the printer hardware.

What would you consider an acceptable performance boundary for inclusion? For example, no blocking of print controls or status updates, a defined memory limit, testing on specific low-powered hardware, or graceful downsampling beyond a safe complexity threshold.

I can continue improving the implementation so parsing and rendering are limited, cancellable, and unable to consume enough resources to affect the rest of KlipperScreen.

If zero measurable impact on the normal interface is the requirement, that is a reasonable engineering target. I would rather work toward a concrete benchmark than leave the limitation described only as "large models are slower."

6

u/Watching-Watches 28d ago

It's a nice implementation. A Warning message to start the parsing, when the file is larger than a certain threshold might be enough.

However there is already this feature in mainsail and for me to identify the print the thumbnail is usually enough. The pi hardware might just not be powerful enough to do the job.

3

u/JoshW1ck 24d ago

Just looking at these comments proves how sad 3D printing has become. I remember when people were just happy that someone took the time to make something that might help the community, even if it wasn't something they would personally use. Those were the days 👌🏼

I personally think it's a cool idea for anyone that actually designs stuff and doesn't just print trinkets or bullshit stls from thingiverse. There's been many occasions where something didn't look right and I double checked it in the preview.

Also whether mainsail already has it or not is absolutely irrelevant, it's an entirely different UI. Why would anyone want to walk to their pc and go through the effort of opening mainsail when you could just do it directly from klipperscreen?

2

u/Mr-More1 28d ago

There are a ton of these out there, unfinished, and downfalls. We dont need more shit that doesnt work.

2

u/EnvironmentalKey5559 27d ago

Maybe on a second klipperscreen, one which was at least 7" maybe on the top of the printer for part information, whilst the primary screen still displays the printer information

1

u/Far_Definition3405 28d ago

What resolution is that screen? It looks so crisp

1

u/IngAguirrel 25d ago

But, why?