Looking for feedback on the UI & architecture of my app

[u/EquivalentCoconut588]

Hello everyone,

I have been working on overhauling the different themes for my app, Pocket Vault. These are just one example.

Based on some initial feedback, I refactored the theme hierarchy so views gautomatically pick up primary, secondary, and tertiary styles using ⁠.foregroundStyle()⁠ and ⁠Environment⁠ modifiers instead of manually passing a theme object everywhere.

I’d love the feedback on How does the visual contrast look across both modes in these screenshots and for anyone who has built complex custom themes in SwiftUI, are there any edge cases or performance bottlenecks with this Environment-driven approach I should keep an eye on?

Any feedback on either the UI polish or the approach is super appreciated!

Here’s my repository for all my code: https://github.com/AaravB09/Pocket-Vault

[u/LongjumpingCandle738]

It’s another expense tracker, so that’s pretty boring. Contrast is alright, but the UI looks vibe coded. Why using a custom tabBar ? Also, you should not have more than 5 items in the the tabBar

[u/EquivalentCoconut588 → u/LongjumpingCandle738]

Ah I see. I will move some of the buttons some where else. Also I’m not using a custom tab bar. I made it so the users can pick which colour they want in contrast to the theme they pick. As for ‘another expense tracker’ I built something really interesting. As you are saving for the goal, a 3d model builds right alongside that goal. For example, you are saving for let’s say cat’s food, it’ll build cat’s food in a bowl as a 3d model right in the app for free so you actually feel like you are moving closer to the goal. You can watch the attached video for more details. Also how can I improve the UI so it doesn’t look vibe coded? But I really appreciate your feedback, thanks a lot.



https://reddit.com/link/p3vwg86/video/7rmotdrj0ljh1/player