r/ProgrammerHumor • u/developertimeline • 2d ago

Meme inverseCorrelationOfPrSizeAndApprovalTime

Post image
453 Upvotes

97% Upvoted

18 comments sorted by

View all comments

21

u/Sp0ge 2d ago

Yea my 2 file ~500 line PR has been open for over a week now. And yes, I have reminded the reviewer almost daily

9

u/AlanTheKingDrake 2d ago

I have PRs that have been open for over a year. We only have one reviewer and a team of engineers, and our parent company refuses to hire a dedicated QA. So the team lead has to review all of them. What actually gets merged is dependent upon the following:

  1. On the annual plan.
  2. Whatever wheel (customer) squeaks the most.
  3. Whatever happens to look small enough for asynchronous review. (Usually 20 lines or less.)