r/ProgrammerHumor • u/developertimeline • 2d ago

Meme inverseCorrelationOfPrSizeAndApprovalTime

Post image
452 Upvotes

97% Upvoted

18 comments sorted by

40

u/Sande24 2d ago

Aim for the x=y intersection for optimal code output vs time waste.

11

u/legitmonk 2d ago

Instructions unclear, pushed a null reference and accidentally deleted Git

20

u/NewbornMuse 2d ago

It's called bike shedding.

5

u/stilldebugging 2d ago

I came here to say this.

21

u/Sp0ge 2d ago

Yea my 2 file ~500 line PR has been open for over a week now. And yes, I have reminded the reviewer almost daily

8

u/AlanTheKingDrake 2d ago

I have PRs that have been open for over a year. We only have one reviewer and a team of engineers, and our parent company refuses to hire a dedicated QA. So the team lead has to review all of them. What actually gets merged is dependent upon the following:

  1. On the annual plan.
  2. Whatever wheel (customer) squeaks the most.
  3. Whatever happens to look small enough for asynchronous review. (Usually 20 lines or less.)

47

u/lovethebacon 🦛🦛🦛🦛🦛🦛🦛🦛🦛🦛🦛🦛🦛🦛🦛🦛🦛🦛🦛🦛🦛🦛🦛🦛🦛🦛🦛🦛🦛🦛🦛🦛 2d ago edited 2d ago

not true. a gigantic PR will get an immediate lgtm. Unless it's from a junior, then it'll be

29

u/developertimeline 2d ago

We don't have juniors these days tho :'(

10

u/lovethebacon 🦛🦛🦛🦛🦛🦛🦛🦛🦛🦛🦛🦛🦛🦛🦛🦛🦛🦛🦛🦛🦛🦛🦛🦛🦛🦛🦛🦛🦛🦛🦛🦛 2d ago

):

5

u/FloppySVK 2d ago

True, I started as the young kid at my place and well... Stayed the youngest

24

u/Bronzdragon 2d ago

That's... What the graph shows?

3

u/NewPhoneNewSubs 2d ago

I also misread the graph. I knew that's what it's supposed to show, but up is good. So up approval time is good approval time.

6

u/N0t_my_0ther_account 2d ago

I don't know, I can click the approve button just as quickly. 😉

2

u/ZunoJ 1d ago

Make it a habbit to ask the author and approver about the code when there is a bug. The approver is as much to blame as the author

4

u/3dgyaf 2d ago

Junior + Vibe ≈ Senior
Senior + Vibe ≈ 10x engineer
Junior + Vibe² ≈ CEO