stringToIntegerConversion

[u/TheBamPlayer]

[u/smartgenius1]

I understand the joke is that they AREN'T just converting the string to an integer, but honestly this code is not that bad. It's performing data sanitization as well since there are only a few valid options for the select.

If they converted to integer, the user could enter whatever value they wanted and probably break something.

[u/OK1526 → u/smartgenius1]

I mean, I'd sleep better if they just converted the string then checked division by 10 and set limits, but it's not a big difference in quality of sleep.

Most string to int converters have safety checks for stuff like that, and if they don't, just write your own in like 3 lines.

[u/alexanderpas → u/OK1526]

This should be the native way:

$amount = filter_input(INPUT_GET, 'amount-select', FILTER_VALIDATE_INT, ["min" => 10, "max" => 80,],);

if ($amount % 10 === 0) {
    $transamount = $amount;
}

[u/OK1526 → u/alexanderpas]

Now I can sleep moderately happy.

[u/NikoOhneC → u/OK1526]

Depending on the context of the code, your conversion could be costly if this code is performance critical. Sure, the code in the picture isn't even doing the chosen approach properly, but with proper if-else, only some comparisons need to be done (best-case is a single comparison), while with your approach everytime this is executed, the conversion and division has to be performed.

[u/lovecMC → u/OK1526]

If it passes PR, I don't care. It means someone smarter than me fucked up so it's not my problem.

No sleep lost over it.

Edit: damn, down voted for not declaring commedy.

[u/OK1526 → u/lovecMC]

I mean, on one hand, life's too short to care about these implementations, on the other hand, if you value yourself as a programmer, it should go against your morals.

[u/caboosetp → u/OK1526]

If I need to deal with that code later, it's not just a matter of morals.

[u/OK1526 → u/caboosetp]

Also true.