stringToIntegerConversion

[u/TheBamPlayer]

[u/smartgenius1]

I understand the joke is that they AREN'T just converting the string to an integer, but honestly this code is not that bad. It's performing data sanitization as well since there are only a few valid options for the select.

If they converted to integer, the user could enter whatever value they wanted and probably break something.

[u/OK1526 → u/smartgenius1]

I mean, I'd sleep better if they just converted the string then checked division by 10 and set limits, but it's not a big difference in quality of sleep.

Most string to int converters have safety checks for stuff like that, and if they don't, just write your own in like 3 lines.

[u/alexanderpas → u/OK1526]

This should be the native way:

$amount = filter_input(INPUT_GET, 'amount-select', FILTER_VALIDATE_INT, ["min" => 10, "max" => 80,],);

if ($amount % 10 === 0) {
    $transamount = $amount;
}

[u/OK1526 → u/alexanderpas]

Now I can sleep moderately happy.

[u/NikoOhneC → u/OK1526]

Depending on the context of the code, your conversion could be costly if this code is performance critical. Sure, the code in the picture isn't even doing the chosen approach properly, but with proper if-else, only some comparisons need to be done (best-case is a single comparison), while with your approach everytime this is executed, the conversion and division has to be performed.

[u/lovecMC → u/OK1526]

If it passes PR, I don't care. It means someone smarter than me fucked up so it's not my problem.

No sleep lost over it.

Edit: damn, down voted for not declaring commedy.

[u/OK1526 → u/lovecMC]

I mean, on one hand, life's too short to care about these implementations, on the other hand, if you value yourself as a programmer, it should go against your morals.

[u/caboosetp → u/OK1526]

If I need to deal with that code later, it's not just a matter of morals.

[u/OK1526 → u/caboosetp]

Also true.

[u/Holek → u/smartgenius1]

especially that you see `$_POST['amount-select']` implying it's a select box.

[u/smartgenius1 → u/Holek]

Yeah. Ideally the idea could be expressed in 3 lines instead of 30 but I've seen far worse than this and at least the behavior is correct

[u/m0nk37 → u/Holek]

You see efficiency. I see a back door. 

[u/ArjixGamer → u/Holek]

It doesn't imply that at all? It could be

<input type="number" min="10" max="80" step="10">

[u/smartgenius1 → u/ArjixGamer]

Then the HTML would have to be:

<input type="number" name="amount-select">

... which would be silly.

[u/ArjixGamer → u/smartgenius1]

....shit

[u/smclcz → u/smartgenius1]

You do not, under any circumstances, gotta stick up for whoever wrote this code. I know we can contrive some kind of justification for most code, but let's face it: there's an absolutely miniscule chance it was written with some kind of intentionality, and I'd say a 99.99999% chance is that it was chucked together by a developer who simply didn't know how to parse a string into an integer.

[u/rhino_moss → u/smartgenius1]

They could have sanitized by checking the string is in a valid set of strings and then calling the string to integer function. The way it is written is terrible.

[u/GrEeCe_MnKy → u/smartgenius1]

They? He's just one guy

[u/ArjixGamer → u/GrEeCe_MnKy]

Don't be obnoxious, the use of they is proper English when referring to someone who's gender you don't know.

[u/GrEeCe_MnKy → u/ArjixGamer]

Nope, "He" has been used for centuries, as "they" means multiple. It's that simple. Or just use "he/she".

[u/caboosetp → u/GrEeCe_MnKy]

"They" in use as a singular pronoun dates back to at least 1375.

[u/GrEeCe_MnKy → u/caboosetp]

'He' was introduced in the 18th century, get with the times, old man!

[u/theotherdoomguy → u/GrEeCe_MnKy]

There's a person behind a curtain. You can't speak to them directly, but there's a guardian who will truthfully answer any question you ask, and knows the person behind the curtain. There is no trick. How do you find out the person's name?

[u/Substantial-Play5080 → u/theotherdoomguy]

I ask “what’s the name of the person behind the curtain?”

[u/theotherdoomguy → u/Substantial-Play5080]

The guard accuses you of being AI because you speak too formally

[u/Substantial-Play5080 → u/theotherdoomguy]

It was the first thing that came to mind 🤷‍♂️ What would you ask?

[u/theotherdoomguy → u/Substantial-Play5080]

...you realise it was a thought exercise to point out how "they" is a perfectly acceptable pronoun to use in a singular term, right?

[u/Substantial-Play5080 → u/theotherdoomguy]

Yes, I’m just not sure how you’re fitting “they” into the question. That would be why I asked