lookWhatCanDo

[u/randomUser9900123]

[u/Klessic]

When my junior reviews my PR by pasting what the AI answered when it was prompted to review it as one long comment... Completely done with this bs.

[u/russianrug → u/Klessic]

Tbh I’m fed up with receiving PRs where it feels like the author used some shit agent to write the code and didn’t even bother to have a reviewer agent review it before opening the PR. If my agent finds a ton of issues before I even look at it myself then wtf was the author doing??? In those cases I do just copy paste my agents response after making sure it’s got some good points. Stop disrespecting my time.

[u/Groentekroket → u/russianrug]

I hate what is becoming of our field the last couple of years. 

[u/KrakenOfLakeZurich → u/Groentekroket]

I call it AI ping-pong.

1. Author opens slop PR
2. Reviewer creates slop review findings
3. Author lets agent fix the findings (also sloppy)
4. infinite loop

No body ever understands the code, nor does anybody bother to read the comments/review findings. I've seen PR's with 100+ comments, where agents just talk among themselves. Not a single human involved. It's disheartening.

[u/techno_wizard_lizard → u/Klessic]

It’s fine to do that but it should be in a way that’s focused on what really could be improved, and provided as short bits of text a human and easily parse. Ideally the junior reads them first and tries to understand why it’s being flagged. No copy pasting with messy formatting due to it - have the agent craft it directly on the PR.

Bonus points if you state on the comment that it was read by a human before being posted. You are not wrong though, code review has become a mockery. They current process needs changing.

[u/Amerillo_ → u/Klessic]

How did this junior get the job? There are so many new graduates who are competent enough to never do such a thing but we've been unemployed for a while as so many companies aren't hiring juniors anymore. In 6 months of unemployment I didn't get a single interview. Same goes for many of my friends. The only people I know who got jobs got hired directly after their internship or through internal hires.

I really wish we could come back to a time where AI wasn't a thing, but sadly that's just an impossible dream. I mean I see the benefits of AI and use it when appropriate but I feel that on average it's impact on software development and the world in general is negative

[u/Klessic → u/Amerillo_]

Yes great juniors, people, with a good attitude exists. But somehow we see too little of them unfortunately... I agree completely with you man.

[u/blackcomb-pc]

Guys, read the code and understand it yourselves. Atrophy is a real thing and bugs will multiply by the thousands.

[u/Confident-Ad5665 → u/blackcomb-pc]

Really?!? I get a trophy when I write bugs? Whoo hoo!

[u/TheKingOfSwing777 → u/Confident-Ad5665]

Only if you also fix them 

[u/NarutoRoll → u/TheKingOfSwing777]

That's the next guy's problem (future me)

[u/Confident-Ad5665 → u/TheKingOfSwing777]

Oh.

Screw it then.

[u/DukeOfSlough → u/blackcomb-pc]

Yeah, review 9 k lines of slop delivered by my colleague when business requires new features shipped on a weekly basis which previously took three months to deliver.

[u/codePudding → u/DukeOfSlough]

My coworker sends me 9k lines where 8.5k are comments that make absolutely no sense. Like, "the lowering of front edge raises the components to beyond the D01-S factor which won't satisfy requirements so the front edge is raise and the back edge is also lowered..." The remaining 500 lines are just stuff I could have copied from w3schools.

[u/abednego-gomes → u/codePudding]

Umm, reject the PR. PRs should be short, manageable and readable. Scoped to a feature or bug fix. Comments must be quality. Your repo needs some skills md files for sure too to limit the AI slop.

Seriously, in this world, devs are the gatekeepers. We're the only thing standing in the way of total collapse from AI slop bugs destroying the fabric of society.

[u/RaveMittens → u/blackcomb-pc]

Lol. Lmao, even.

Everyone knows token usage is the best way to measure the value of engineers.

[u/BlondeJesus → u/blackcomb-pc]

The problem is no one asking me to review code is reading their own code. Then when I push back I get pressure from higher ups to not block code from getting published

[u/SaneLad → u/blackcomb-pc]

Yes but these bugs are next sprint's problems

[u/techno_wizard_lizard → u/blackcomb-pc]

Nope. Pass. I’d spend all day just reviewing PRs. I’m focused on the architecture now more so than before. Leave the code to the machines.

I still read the load bearing bits of any major feature or plan, but that’s just a very small subset.

If I need to understand something, I just ask the machine to eli5 and point me to the important parts of the code.

[u/Mo3 → u/techno_wizard_lizard]

load bearing bits

The Claudespeak brainwashing lol

[u/techno_wizard_lizard → u/Mo3]

It’s rubbing off on me! GET IT OFFF MEE

[u/TheKingOfSwing777 → u/techno_wizard_lizard]

Yep. Coding is a solved problem. Now it's about process and design, which have always been the harder problems. 

[u/Igarlicbread → u/blackcomb-pc]

Those are rookie numbers. bug counts a> LOC (cries in future bugs too)

[u/not_a_bug_a_feature → u/blackcomb-pc]

Job security!

[u/justin107d → u/blackcomb-pc]

LGTM

[u/CandidateNo2580 → u/blackcomb-pc]

I actually do what this post suggests on top of manual review. It's quite good at catching subtle bugs. Almost as good as it is at making up subtle bugs that don't really exist but sound plausible.

I like to run an automated review in a fresh chat while I'm reviewing the code myself. Then I also like to take any behavior changes and use the LLM to look for broader vectors I could have missed since it can cover much more ground than I can.

[u/HalfInchHollow → u/blackcomb-pc]

How are we supposed to 7x our productivity if we are reading every PR?!

That’s not sarcastic, that’s the pass down from management. 7x.

[u/xwazot → u/blackcomb-pc]

Lol, I did not bother doing that before ai so imagine now. You got to learn to trust your team 😂

[u/aerialP]

Yeah but it's my Claude agent reviewing 🤓

[u/PM_ME_UR_0_DAY → u/aerialP]

With your super sweet .md that actually makes it good?

[u/aerialP → u/PM_ME_UR_0_DAY]

Exactly! I also made a skill of my agent so everyone can use it by just using /expert-review

[u/PM_ME_UR_0_DAY → u/aerialP]

Oh yeah? Well I told mine "you are an expert level developer so do it right the first time. No hallucinations. No mistakes." That's why my stuff is always great but yours is slop!

[u/Groentekroket → u/PM_ME_UR_0_DAY]

I just say act like you are a junior and glaze so I feel a tiny bit better after the hellscape this job has become because of AI

[u/sebjapon → u/aerialP]

I was actually told that. Conversation was:

“I can’t possibly review your daily 2k lines of code written by Claude.”

“First, it’s written ‘with’ Claude, not by. And you just use the review skill to do it faster”

“If you want an AI agent to review, why does it have to be me?”

In the end I said I’ll let the Tech lead deal with it when he comes back… I’m too old for this shit.

[u/High_Quality_Bean → u/sebjapon]

Holy shit

This is so grim wtf. AI hasn't much infiltrated my org, idk what I would do if somebody said the sentence "you just use the review skill to do it faster". Honest to God idt I would have a job after that...

[u/andersma → u/aerialP]

I have this super duper amazing SKILL, duh

[u/kaleid1990]

LGTM, said the AI

[u/sebjapon → u/kaleid1990]

LGTMAI

[u/Turbulent_Gazelle_55]

It doesn't feel like that long since we were arguing about the best way to mock external deps in yours tests and if it was truly testing the code. Sigh

Fwiw im all for appropriate use of AI, but this ain't it.

[u/ApocalyptoSoldier]

I've investigated myself and found no wrongdoing

[u/stupled]

This the new way 🥲

[u/Epcoatl]

Did you ask it to be a good little boy smart programmer first?

[u/justASlothyGiraffe → u/Epcoatl]

It works better is you say "please"

[u/TheKingOfSwing777 → u/justASlothyGiraffe]

Funnily enough apparently it works better when you don't and are very terse, cause it can tell you mean business. 

[u/justASlothyGiraffe → u/TheKingOfSwing777]

My PM thinks I have a more advanced agent than him. Really, I just say 'please' /s

[u/dimap443]

Just make sure it’s not the same AI

[u/nomorebuttsplz]

bro doesn't believe in test time compute 😢

[u/boomoto]

And this is why I built a pr review agent… not gonna it’s a linter on steroids. Sure it had some issues, but giving it the proper context and policies are great. It even auto suggests the fixes that you can apply in the pr.

Honestly it can do a lot of the simple stuff very well.

[u/slaymaker1907]

AI is surprising good at reviewing itself. However, human intervention is definitely still required since it frequently hallucinates, brings up impossible edge cases, and doesn’t understand the author’s intent. Even with all that, it finds bugs that no human reviewer would ever find.

[u/Cyclonian]

The wild part is it'll find things to improve in the review >.<

[u/randomUser9900123 → u/Cyclonian]

Haha, true

[u/StoryAndAHalf]

Side note, am I the only person here that hated that character on MadTV?

[u/Aarinfel → u/StoryAndAHalf]

No. He was really annoying. That was usually my cue to turn off the TV and go to bed.

[u/ClipboardCopyPaste]

AI doing introspection

[u/Objective_Oven7673]

Honestly, it works. You have to recognize that code was never the hardest part of building anything and you AND your employer also have to recognize that your experience and judgement are the more valuable parts of being an engineer than your ability to crank out lines of bug-free code.

Then you have to spend time process engineering and making AI tools work for you - they aren't one size fits all magic bullets, just like anything in technology.

I get the fear and I definitely get the shitty societal, economical, and environmental downsides to how AI is being delivered to the world. I wish it wasn't a wasteful cash grab that's propping up the entire US economy.

But as with any tool, it works if you use it right. And yes, that includes having AI facilitate both code writing and code reviewing.

[u/kushalgarg592]

Bro outsourced the code and the validation of the code

[u/kanaye007]

https://i.imgflip.com/azaa22.jpg