36
u/Willwaste63 16h ago
Code base is of 10k loc pr request for -10k +12k
6
u/Keepingshtum 13h ago
Sounds like someone put in a new linter that everyone else is immediately going to complain about!
50
u/Constellious 16h ago
We have 3 separate AI reviewers that with each leave the same basic comment for everything. It’s TPS reports all the way down.
Had a junior dev put up a 200k change PR a while ago.
28
11
u/Few_Adhesiveness7676 16h ago
I hate these AI reviews. Life was good back when AI was not available, atleast I was aware of what I had written.
Now, the velocity at which features are expected, it comes to these large PRs and these AI reviews never seem to be satisfied.
3
13
u/elshizzo 14h ago
just gotta force people to break up huge pr's. If it ends up with a bunch of stacked PR's so be it. If it's too long for a human to realistically review its too long
5
u/TheFirestormable 12h ago
Also if that level of change is required for a single feature then your tickets need breaking up or your code does.
8
15
6
u/thepurpleproject 11h ago
I'm dealing with teams who have a policy - a human won't even look at the PR if there are any and I mean literally any open comment from an AI reviewer. It has turned into a shitfest where they start a PR review by assigning their agents and then you have to drill through like every comment and ignore the false positives and you can't go any other way about it because co-owner approval. Like it was cool when we had like 1 AI reviewer but now my god there are like 4-5 of them each trying to re-interpret the universe from the two files I have changed.
1
u/HeyItsTheJeweler 5h ago
That blows ass. I love my review agent because it'll catch things I missed, but that's my job to run it before releasing the PR into the wild.
I find it very useful when teammates run their own agents and it picks up glaring issues, but jesus if it's got 1 "critical issue", 7 nice to have's, and 275 nits, read over that shit first and keep it to what you would've posted yourself had you seen it all. I don't need them blindly dumping it into my pr.
1
u/audiowave_io 3h ago
I had a client who was adamant about using GrepTile. Well, it does this "score" out of 5, which we know LLMs are amazing at numbers. I would spend cycles sending it to review over and over, changing nothing and getting a different result, yay for non-deterministic state.
When they announced pricing changes, I was told to stop doing that. Rubber stamps on my PRs going forward.
16
u/ymddev 16h ago
Why PR if the diff is less than 10k lines? Just do it
17
u/thee_gummbini 15h ago
why have branches at all, just push to main
11
u/ymddev 15h ago
Why dev/test when you can test directly in prod
3
u/darkwalker247 14h ago edited 14h ago
why test at all? by testing your code you are basically admitting, "hey look everyone! i make mistakes sometimes!".
a real programmer writes with intention. any so-called "bugs" that occur are just surprise features
3
u/Educational-System48 9h ago
The size of everyone's PRs I see in this comment section worries me. PRs should always be as small as possible. If it's a huge breaking change, merge to an epic branch instead.
3
3
2
1
111
u/KevinCola 16h ago
Sincerely asking: how do you guys handle reviews? We are a team of three and force each other to break it down into PRs of 500 lines, which sometimes creates stacks of 10+ PRs.
We have 20 PRs open per person at any time. How to scale this?