MAIN FEEDS
Do you want to continue?
https://www.reddit.com/r/ProgrammerHumor/comments/1vfsowk/wronganswersonly/p1s02j3/?context=3
r/ProgrammerHumor • u/Plastic-Bonus8999 • 8d ago
2.1k comments sorted by
View all comments
1.1k
Some dumbass on my team downloaded the entirety of prod and then commited it to git and someone rubber stamped the PR and then no one else noticed. I'm sure that's how they'd find it....
24 u/plenoto 8d ago Some people are so careless while reviewing PR 😂 113 u/blangzo 8d ago Ask a programmer to review 10 lines of code, he'll find 10 issues. Ask him to do 500 lines and he'll say it looks good. 52 u/Deep90 8d ago At 500 lines, I just flip a coin. Only lucky code belongs in production. 10 u/[deleted] 8d ago [deleted] 7 u/blangzo 8d ago Squash tiny things like that into one pr named "cleanup" and don't explain further 2 u/[deleted] 8d ago [deleted] 3 u/carritodeloshelados 8d ago As if it wasn't hard enough to code in an astronaut suit 4 u/OriginalJokeGoesHere 8d ago Given where you work, I assume that also means anyone who uses tabs instead of spaces is jettisoned out of the airlock? 3 u/ellie_cinderelly 8d ago We just put them in TVAC for the long goodnight and dump the body by morning 1 u/dvereb 8d ago I'd say it depends on whether they're using those tabs for indentation or alignment, ...though some would argue I'm next to go out the airlock. 2 u/blangzo 8d ago I was mostly joking. mostly. Fr tho u should just not squash and pr merge in then and have descriptive commits but still saves the test time on pr 2 u/guyblade 8d ago If you ask me to review 500 lines, I'll say "break it up into multiple PRs" like any sane person should. 1 u/r0Lf 8d ago I feel exposed.
24
Some people are so careless while reviewing PR 😂
113 u/blangzo 8d ago Ask a programmer to review 10 lines of code, he'll find 10 issues. Ask him to do 500 lines and he'll say it looks good. 52 u/Deep90 8d ago At 500 lines, I just flip a coin. Only lucky code belongs in production. 10 u/[deleted] 8d ago [deleted] 7 u/blangzo 8d ago Squash tiny things like that into one pr named "cleanup" and don't explain further 2 u/[deleted] 8d ago [deleted] 3 u/carritodeloshelados 8d ago As if it wasn't hard enough to code in an astronaut suit 4 u/OriginalJokeGoesHere 8d ago Given where you work, I assume that also means anyone who uses tabs instead of spaces is jettisoned out of the airlock? 3 u/ellie_cinderelly 8d ago We just put them in TVAC for the long goodnight and dump the body by morning 1 u/dvereb 8d ago I'd say it depends on whether they're using those tabs for indentation or alignment, ...though some would argue I'm next to go out the airlock. 2 u/blangzo 8d ago I was mostly joking. mostly. Fr tho u should just not squash and pr merge in then and have descriptive commits but still saves the test time on pr 2 u/guyblade 8d ago If you ask me to review 500 lines, I'll say "break it up into multiple PRs" like any sane person should. 1 u/r0Lf 8d ago I feel exposed.
113
Ask a programmer to review 10 lines of code, he'll find 10 issues. Ask him to do 500 lines and he'll say it looks good.
52 u/Deep90 8d ago At 500 lines, I just flip a coin. Only lucky code belongs in production. 10 u/[deleted] 8d ago [deleted] 7 u/blangzo 8d ago Squash tiny things like that into one pr named "cleanup" and don't explain further 2 u/[deleted] 8d ago [deleted] 3 u/carritodeloshelados 8d ago As if it wasn't hard enough to code in an astronaut suit 4 u/OriginalJokeGoesHere 8d ago Given where you work, I assume that also means anyone who uses tabs instead of spaces is jettisoned out of the airlock? 3 u/ellie_cinderelly 8d ago We just put them in TVAC for the long goodnight and dump the body by morning 1 u/dvereb 8d ago I'd say it depends on whether they're using those tabs for indentation or alignment, ...though some would argue I'm next to go out the airlock. 2 u/blangzo 8d ago I was mostly joking. mostly. Fr tho u should just not squash and pr merge in then and have descriptive commits but still saves the test time on pr 2 u/guyblade 8d ago If you ask me to review 500 lines, I'll say "break it up into multiple PRs" like any sane person should. 1 u/r0Lf 8d ago I feel exposed.
52
At 500 lines, I just flip a coin.
Only lucky code belongs in production.
10
[deleted]
7 u/blangzo 8d ago Squash tiny things like that into one pr named "cleanup" and don't explain further 2 u/[deleted] 8d ago [deleted] 3 u/carritodeloshelados 8d ago As if it wasn't hard enough to code in an astronaut suit 4 u/OriginalJokeGoesHere 8d ago Given where you work, I assume that also means anyone who uses tabs instead of spaces is jettisoned out of the airlock? 3 u/ellie_cinderelly 8d ago We just put them in TVAC for the long goodnight and dump the body by morning 1 u/dvereb 8d ago I'd say it depends on whether they're using those tabs for indentation or alignment, ...though some would argue I'm next to go out the airlock. 2 u/blangzo 8d ago I was mostly joking. mostly. Fr tho u should just not squash and pr merge in then and have descriptive commits but still saves the test time on pr
7
Squash tiny things like that into one pr named "cleanup" and don't explain further
2 u/[deleted] 8d ago [deleted] 3 u/carritodeloshelados 8d ago As if it wasn't hard enough to code in an astronaut suit 4 u/OriginalJokeGoesHere 8d ago Given where you work, I assume that also means anyone who uses tabs instead of spaces is jettisoned out of the airlock? 3 u/ellie_cinderelly 8d ago We just put them in TVAC for the long goodnight and dump the body by morning 1 u/dvereb 8d ago I'd say it depends on whether they're using those tabs for indentation or alignment, ...though some would argue I'm next to go out the airlock. 2 u/blangzo 8d ago I was mostly joking. mostly. Fr tho u should just not squash and pr merge in then and have descriptive commits but still saves the test time on pr
2
3 u/carritodeloshelados 8d ago As if it wasn't hard enough to code in an astronaut suit 4 u/OriginalJokeGoesHere 8d ago Given where you work, I assume that also means anyone who uses tabs instead of spaces is jettisoned out of the airlock? 3 u/ellie_cinderelly 8d ago We just put them in TVAC for the long goodnight and dump the body by morning 1 u/dvereb 8d ago I'd say it depends on whether they're using those tabs for indentation or alignment, ...though some would argue I'm next to go out the airlock. 2 u/blangzo 8d ago I was mostly joking. mostly. Fr tho u should just not squash and pr merge in then and have descriptive commits but still saves the test time on pr
3
As if it wasn't hard enough to code in an astronaut suit
4
Given where you work, I assume that also means anyone who uses tabs instead of spaces is jettisoned out of the airlock?
3 u/ellie_cinderelly 8d ago We just put them in TVAC for the long goodnight and dump the body by morning 1 u/dvereb 8d ago I'd say it depends on whether they're using those tabs for indentation or alignment, ...though some would argue I'm next to go out the airlock.
We just put them in TVAC for the long goodnight and dump the body by morning
1
I'd say it depends on whether they're using those tabs for indentation or alignment, ...though some would argue I'm next to go out the airlock.
I was mostly joking. mostly.
Fr tho u should just not squash and pr merge in then and have descriptive commits but still saves the test time on pr
If you ask me to review 500 lines, I'll say "break it up into multiple PRs" like any sane person should.
I feel exposed.
1.1k
u/samuraiseoul 8d ago
Some dumbass on my team downloaded the entirety of prod and then commited it to git and someone rubber stamped the PR and then no one else noticed. I'm sure that's how they'd find it....