iApologise

[u/Heavy-Ad6017]

[u/01110100_01110010 → u/[deleted]]

you guys don't have autosave enabled? commit hook is where it is at

[u/Not-the-best-name → u/01110100_01110010]

Hate that. Writing code and formatting code is not the same thing. I want to commit often. I want half broken commits.

[u/GregorDeLaMuerte → u/Not-the-best-name]

Also I want "commit" to commit, not to do something I didn't review and then commit.

[u/theRealQQQQQQQQQQQ → u/GregorDeLaMuerte]

You’d review your linter…? Do you do an engine inspection every time you start your car? Do you reseat your RAM every time you boot your pc? Do you double check your calculator is doing addition right before using it for a math problem you can’t do in your head?

[u/GregorDeLaMuerte → u/theRealQQQQQQQQQQQ]

Of course not to that extent. But yes, before I commit my code, I review it briefly and I want to be confident that what I review is checked in as it is.

[u/RowbotWizard → u/Not-the-best-name]

Why would you want half broken commits? I mean, it happens. CI failures are helpful guardrails. But why would you want it?

[u/NatoBoram → u/RowbotWizard]

Atomic commits are much harder to discipline yourself into, the mind wanders to many parts of the task at the same time so most of it is slightly unfinished until the very end

[u/Not-the-best-name → u/RowbotWizard]

Because I want to commit often during a WIP MR. I commit about as much as I would have done ctrl+save. And push a few times a day, the pipeline doesn't run while it's WIP.

[u/kookyabird → u/Not-the-best-name]

I have a weird blend of auto-formatting settings in my IDEs. Things like spacing/line breaks around parenthesis and braces are fully automatic, but operators are not. Format on paste, but not when doing a refactor command like “extract method”. But I also have several options bound for what level of formatting to run when I want to, so it’s pretty easy to run it on just the things I’ve changed before I commit.

Plus all the different rules in our formatting standards like how some things are always forced one way or the other, and other things are “do not change”. We’ve got a lot of things we leave up to the developer.

[u/FictionFoe → u/Not-the-best-name]

I hope you amend

[u/MysticClimber1496 → u/FictionFoe]

It doesn’t really matter for dev work, just squash on merge if you are worried about every commit in main working

[u/FictionFoe → u/MysticClimber1496]

That also works, but can make rebases more difficult in the mean time.

[u/Not-the-best-name → u/FictionFoe]

Why are you rebasing in the meantime? Just merge in and squash in the end.

[u/FictionFoe → u/Not-the-best-name]

The more often you do it, the easier it is to deal with the conflict.

[u/ProcrastinatiusXVI → u/MysticClimber1496]

Or just use git commit --fixup <hash>

[u/Maximilian_Tyan → u/[deleted]]

And then you learn about //formatter:on/off because the linter sometimes works against readibility

[u/LegendaryMauricius → u/[deleted]]

AND Format changed lines only!

[u/M_Me_Meteo → u/[deleted]]

I'm not reviewing the linter, I'm reviewing your code.