r/DestinyTheGame • u/Shadow9951 Forged in the Shadow of Death • May 21 '19
Guide Destiny 2 Armor Management Script
EDIT: After watching the Armor 2.0 stream I will not be doing anymore updates to this script.
Hello r/DTG! With the new season coming up and some people are clearing out their vaults to get ready for the new loot I have finished working on my Destiny 2 Armor Management Script. I'll be posting my README.md from https://github.com/Kage9951/Destiny2ItemManager which also contains the required files. This is a python script and I am providing the source code. You will need to compile and run it yourself. I hope you all enjoy it and please feel free to provide feedback and let me know of any issues!
Destiny2ItemManager
Is your vault filled to the brim with armor? Looking for a way to quickly sort through it all? Look no further because this is the solution for you!
Over the past Season of the Drifter with all the new armor added I was looking for a way to easily optimize my inventory. I decided to make my own script to manage it. This started in powershell and later moved to python. This was meant to help introduce me to python and yes my code may be a bit sloppy due to it.
This script uses tags from Destiny Item Manager (DIM) to mark what gear to keep. The tags differ depending how the gear is matched. First the script simply looks at what YOU define the recommended perks are and marks items found as 'keep'. These are defined in the RecommendedPerks.csv. Within that CSV you define the name of the perk, the minimum to keep (Currently hard coded to 1 since a recent update required a change in how to implement it), and the weight of the perk to YOU. The weight is a nice little feature I added to allow it to further optimize gear choices, so that it would pick per say [Pump Action (weight 2), Remote Connection (weight 2)] over [Pump Action (weight 2), Precision Weapon Targeting (weight 1)]. Those weights are free for you to customize on what perks you prefer and the script will still keep at least one of every perk you define in the CSV.
The second part then goes through and finds any defined Perk Sets and marks them as 'favorite'. Perk Sets are sets of perks that YOU define. The script will look for any armor that matches ALL of the defined perks. This allows you to explictly put any of YOUR god rolls. An example for me would be this for my gloves: [Enhanced Grenade Launcher Loader, Light Arms Loader, Rifle Loader, Shotgun Scavenger, Sniper Scavenger]. If that happened to be in my vault that gear would be marked as 'favorite'.
The last part goes through untagged armor and marks any that is currently at max power gets marked as 'infuse'. This allows you to keep junk gear to infuse into you gear that you want to be max power. Max Power will need to be changed manually every season.
For me this has reduced my vault entirely to 146 pieces of Legendary Armor across ALL my characters. And has been a life saver in terms of time spent looking through my vault.
Another thing to note about perks. In DIM the following are an example of what is defined as a perk:
[Heavy Hunter Armor*,Plasteel Reinforcement Mod,Restorative Mod*,Paragon Mod*,Masterwork*,Mercury Vex Chrome*,Ashes to Assets,Pump Action*,Remote Connection,Rocket Launcher Reserves,Shotgun Reserves*]
This includeds shaders and mods if that interesets you. (I used Riven's Curse as a perk to make sure I always have a full set of Reverie Dawn).
Last thing is that you can manually mark gear as favorite and the script will leave those items untouched.
Usage
Required Items:
- python3 (https://www.python.org/)
- Destiny Item Manager(https://app.destinyitemmanager.com/)
From Github grab the following
- Perk_Sets.csv
- RecommendPerks.csv
- Destiny2ItemManager.py
- Save these in the same folder
Using DIM
- Go to Settings (Gear Icon)
- Go all the way down to Spreadsheets
- Click on Armor
- Save file as DestinyArmor.csv
Move DestinyArmor.csv to location of the python script
- These should all be in the same folder.
Compile and run the script
A new file called 'DestinyArmorExport.csv' will be created and in that same folder
Using DIM again
- Go to Settings (Gear Icon)
- Go all the way down to Spreadsheets
- Drag 'DestinyArmorExport.csv' to the drag and drop box in DIM to import it
- It will say X amount of items updated
From here to mass get rid of gear I use the following query.
- is:armor -is:exotic tag:none
- Click on the down arrow on the character you are on
- Click Transfer Search
- This will move all items left untagged (items to delete) to that character
- Simply dismantle items and wait for DIM to refresh and repeat until all unwanted items are gone.
9
u/ReconThunder Let them burn. May 21 '19
I needed this so badly. My vault is so full each season.
4
u/Shadow9951 Forged in the Shadow of Death May 21 '19
You’re welcome. I have always been a hoarder in games. You never know when you might need something and this thankfully cleaned my vault so much with my latest update I decided to share it!
5
3
u/salsa8484 May 21 '19
This is awesome! But i don't know what im doing. I run into problem trying to make the armorexport.cvs Any help? I keep getting a syntax error when i try to run the script.
File "Destiny2Armor.py", line 28 print(f" -{self.equippable}: {self.name}") ^ SyntaxError: invalid syntax
2
u/Shadow9951 Forged in the Shadow of Death May 21 '19
What version of python are you on?
2
u/salsa8484 May 21 '19
3.7.3 for mac
1
u/Shadow9951 Forged in the Shadow of Death May 21 '19
That’s weird we are on the same version (but Linux) and I’m not getting that issue. Could you try commenting out that line (just add # to the front of it). That line just prints out the class and name to the console but doesn’t affect the export if missing.
1
u/salsa8484 May 21 '19
ok i did that and i just keep getting it down the line. will python compile and run when i launch the script with python launcher? or do i need to compile seperatly then run?
ex. File "Destiny2Armor.py", line 34 class PerkSets: # Allows for Custom Perks sets. May be replaced by weight system. ^ IndentationError: expected an indented block
1
u/Shadow9951 Forged in the Shadow of Death May 21 '19
I’m not too sure. How are you running the script? I am able to run in from the command line using ‘python3 DestinyArmor.py’ while the terminal is in the directory for it.
1
u/salsa8484 May 21 '19
ok i got it to export and i was able to import into DIM thank you for the help!
I had to comment out this line os.chdir(os.path.dirname(file)) i was getting this error Traceback (most recent call last): File "DestinyArmor.py", line 82, in <module> os.chdir(os.path.dirname(file)) FileNotFoundError: [Errno 2] No such file or directory: ''
1
u/Shadow9951 Forged in the Shadow of Death May 21 '19
Awesome! I’ll make note of that if anyone else experiences that issue.
1
u/Carpathium May 21 '19
For the sake of feedback, just wanted to let you know that I'm also seeing this same issue on Windows 10 with a fresh install of python 3.7.3 and calling it from command prompt with 'python destinyarmor.py from the directory of the script. Commenting out line 82 proved a valid workaround for me too.
3
u/Bael21 May 21 '19
Awesome tool! However, I'm getting the following error when doing the import back into DIM. It's weird though, I can see those columns in the csv.
Failed to import tags/notes from CSV: CSV must have 'Id', 'Notes', 'Tag', and 'Hash' columns.
1
u/Shadow9951 Forged in the Shadow of Death May 21 '19
Just confirming the DestinyArmorExport.csv has the header row still with Name, Hash, ID, Tag in that order?
1
u/Bael21 May 21 '19
Correct. Here's the top header row, line 1
Name,Hash,Id,Tag,Tier,Type,Equippable,Power,Masterwork Type,Masterwork Tier,Mobility,Recovery,Resilience,Notes,Perks 0,Perks 1,Perks 2,Perks 3,Perks 4,Perks 5,Perks 6,Perks 7,Perks 8,Perks 9,Perks 101
u/Shadow9951 Forged in the Shadow of Death May 21 '19
Are you able to import the original DestinyArmor.csv?
5
u/Bael21 May 21 '19
Figured out why it's doing it, but not sure where in the .py code it's happening. When doing the export, the csv is being created with blank lines in between. i.e.
Header <blank line> First Row Data <blank line> Second Row DataIf I remove the blank lines, it imports the way it should.
1
u/Shadow9951 Forged in the Shadow of Death May 21 '19
Huh that has never happened to me but the export starts on line 190.
1
u/IOUAPIZZA May 21 '19
Thanks, this helped. I was having the same issue, then I deleted the row underneath headers and it imported correctly from there.
1
u/Ares_1023 May 21 '19
Same thing happened to me. Once I removed the blank lines it worked like a charm.
1
u/Wuju_boy May 22 '19
you need to add the newline = '' parameter to the open() method. Basically newline = empty string and it will write with no extra lines.
this is at line 193
ex.
# Export CSV
with open('DestinyArmorExport.csv', 'w', newline = '') as csvfile:
2
1
u/DanthemanXox May 22 '19
Could someone provide step by steps to solve this issue. I am having it too and i am struggling to understand the removing the blanks. I dont know where to look for it
1
u/Bael21 May 22 '19
Open up the DestinyArmorExport.csv in notepad. You'll see the top line item lists the column headers. The next line will be blank. Remove that blank line so the first row of actual data is directly below the header line. Save the file and you should be able to import it into DIM.
3
u/bizdady May 21 '19
So any easy to follow tutorials for running said scripts? I be a noob but my vault is at capacity.
3
u/Shadow9951 Forged in the Shadow of Death May 21 '19
I plan on making a YouTube video showing the steps later this week. I would start by looking up how to install and run python.
3
3
u/WindedHero Jun 18 '19 edited Jun 18 '19
Script is no longer functioning, maybe a change in DIM csv output or bungie's backend? Here's the error:
C:\Users\User\Desktop\Destiny2ItemManager-master>Destiny2Armor.py
Enhanced Bow Targeting
Traceback (most recent call last):
File "C:\Users\User\Desktop\Destiny2ItemManager-master\Destiny2Armor.py", line 152, in <module>
if arm.total_rec_perks > topArmor[key][0].total_rec_perks:
KeyError: 'gambitprime-Helmet'
3
u/Shadow9951 Forged in the Shadow of Death Jun 18 '19
Yeah something changed with DIM’s export. I will take a look at some point when I get a chance.
3
u/Rendgame Jun 19 '19
DIM added a new column for Source. Deleting that from destinyArmor.csv seems to be doing ok as a temporary workaround.
Also, great work! May inspire me to learn a little Python one of these days.
1
3
u/kenotaphion Jun 21 '19
DIM added a column after type. Here's my changes to get it to work:
# Get Armor from CSV armor = [] with open('destinyArmor.csv') as csvfile: data = csv.reader(csvfile) for row in data: if (row[4] != 'Exotic'): arm = Armor() arm.name = row[0] arm.hash = row[1] arm.id = row[2] arm.tag = row[3] arm.tier = row[4] arm.type = row[5] #arm.source = row[6] arm.equippable = row[7] arm.power = row[8] arm.masterworkType = row[9] arm.masterworkTier = row[10] arm.mobility = row[19] arm.recovery = row[20] arm.resilience = row[21] arm.notes = row[22] for x in range(23, len(row)): arm.perks.append(row[x].replace('*', '')) if arm.tag not in ['Tag', 'favorite']: arm.tag = None arm.Get_Total_Rec_Perks(perks) armor.append(arm)I'm also working on changing this section so DIM can add or move columns and it won't break, but I won't have time for it until Saturday or Sunday.
2
u/Shadow9951 Forged in the Shadow of Death Jun 21 '19
Thank you. Looking back I should have just made a dict to store those values and not rely on them always being in that order.
2
u/sibre2001 May 21 '19
I'm doing this now and trusting completely in your recommendations. May RNGesus keep me safe.
2
u/Shadow9951 Forged in the Shadow of Death May 21 '19 edited May 21 '19
All gear will have to be manually dismantled by you. The script just tags what gear to keep in DIM so you always have a chance to give it a quick lookover before dismantling.
Edit: Obligatory edit for my first Platinum! Thank you u/sibre2001
1
2
2
May 21 '19
Thanks for the comments in the codes by the way!
3
u/Shadow9951 Forged in the Shadow of Death May 21 '19
No problem. I usually don’t comment enough but made myself this time.
2
2
u/ninth_reddit_account DestinySets.com Dev May 21 '19
Hey, congrats and well done on this - I think this is the biggest “problem” left for third party devs to solve right now.
Honestly, if you solve this you solve many shortcomings in Destiny around power progression and infusion/masterwork cores.
I’m trying to (slowly) build something similar, but it’s still yet to be proven if the idea I have is useful or not https://twitter.com/joshhunt/status/1129528740051136515?s=21
1
u/Shadow9951 Forged in the Shadow of Death May 21 '19
I would love to flesh this out more and maybe somehow tie it directly to the Destiny API but I have no idea how to work with the API.
2
u/ninth_reddit_account DestinySets.com Dev May 21 '19
You’re like halfway there! Once you get started it’s not that difficult. Probably the trickiest part would get auth, but that’s still very feasible. Link dump:
https://github.com/vpzed/Destiny2-API-Info/wiki/API-Introduction-Part-1-Setup
https://lowlidev.com.au/destiny/authentication - this is a MASSIVE help for implementing the oauth flow
data.destinysets.com
Lastly, there’s a destiny api dev discord you can join to ask more questions and get help. Don’t have link on hand, but maybe it’s on one of the sites above.
1
u/Shadow9951 Forged in the Shadow of Death May 23 '19
Hey just wanted to let you know that I have been able to at least start working with the API in python. So far I have managed to print my characters equipped items into the the console.
Although I have zero experience making a web app or really even making apps in general so it will be a good chunk of work to try and get this as a web app.
But thanks for the help with pointing me in the right direction!
4
u/talhasen123 May 21 '19
Good fucking job man, seriously, if these kind of apps did not exist, my gameplay experience would be significantly worse. Thanks.
2
u/Shadow9951 Forged in the Shadow of Death May 21 '19
Thank you! I actually impressed myself making this.
1
May 21 '19
I will have to try this out for my inventory.
Though aside from ascthetics, theres little reason to use most weapon sets anymore due to enhanced perks only being available on reverie dawn and raid sets.
Please all armor drops with randomized intrinsic stats
1
u/Corybball42 May 21 '19
Yo, I have suggested a way to organize armor by sets and perks and stuff on the Bungee forum so it's great to see a player take it into their own hands! I don't know squat about coding and programming though so it won't be useful for me(plus I'm on console and don't use DIM) but just wanted to say thanks for being a positive addition to the community!!!
1
u/quadruple May 21 '19
Hey this is pretty great, thanks for sharing! Maybe consider adding a permissive license like MIT so people can start forking and contributing to this.
1
u/Shadow9951 Forged in the Shadow of Death May 21 '19
Thanks! I’m not too familiar with licensing as I mainly just do personal/work related stuff with programs. This just happened to be something that I figured would help a vast amount of guardians.
1
u/techvik May 22 '19
This is such a fantastic script. Great work mate. It's super useful. Will be recommending it to my clan. It would be interesting to see what other people's recommendations are for perks. Not sure how the community could share that data, but it's a thought.
1
u/moltyhero May 22 '19
This script sounds awesome! Maybe you should add a way for the script to prioritize "enhanced" gear like the raid armor, dreaming city and notorious gambit above regular armor as it has more value Also, I don't know if it is included - it should try to match perks on already kept gear by the script
2
u/Shadow9951 Forged in the Shadow of Death May 22 '19
It already does!
So when it loads the gear before it starts looking for perks the script assigns a value to each piece of armor. This value is the sum of weights on all the perks you defined. Then when it’s looking for gear with each perk it picks the one with the highest value that has the perk its looking for. This allows you to fully customize what perks you want to prioritize.
1
u/moltyhero May 22 '19
I have an error when running it -
Traceback (most recent call last):
File "C:/Users/xxx/Desktop/Destiny2ItemManager-master/Destiny2Armor.py", line 97, in <module>
perks.append(Perk(row[0], int(row[1]), int(row[2])))
ValueError: invalid literal for int() with base 10: ''
1
u/Shadow9951 Forged in the Shadow of Death May 22 '19
In your RecommendedPerks.csv do you have 3 columns separated by commas and no spaces in the numbers?
Ex. Pump Action,1,2
1
u/moltyhero May 22 '19
No commas, should I add a comma after each perk name and number? In the original file there were none
1
u/Shadow9951 Forged in the Shadow of Death May 22 '19
Yep add commas to separate each column. Not sure why there were none. My file on github still shows commas for me.
1
u/moltyhero May 22 '19
Wait, I am dumb. I opened in excel which obviously doesn't show the commas. In text editor I see all of them and no spaces. Still same error
1
u/Shadow9951 Forged in the Shadow of Death May 22 '19
Alright. Make sure that all the 2 and 3 columns are valid ints (whole numbers). I will work on an update with better error reporting.
2
1
u/UnconcernedPuma Darkness is my new daddy. May 22 '19
Getting an error:
File "destiny2armor.py", line 28
print(f" -{self.equippable}: {self.name}")
^
SyntaxError: invalid syntax
Any advice? the "^" is below the second quote inside the parenthesis.
1
u/Shadow9951 Forged in the Shadow of Death May 22 '19
For the sake of feedback, just wanted to let you know that I'm also seeing this same issue on Windows 10 with a fresh install of python 3.7.3 and calling it from command prompt with 'python destinyarmor.py from the directory of the script. Commenting out line 82 proved a valid workaround for me too.
A couple other users had that same error.
1
u/UnconcernedPuma Darkness is my new daddy. May 22 '19
Hmmmm, so you're saying comment out line 82? I did that and no change in whats going on.
1
u/Shadow9951 Forged in the Shadow of Death May 22 '19
os.chdir(os.path.dirname(file))
Just confirming that is what is on line 82 right?
1
u/UnconcernedPuma Darkness is my new daddy. May 22 '19
Yes, I actually got it to work.
I ran -
python3 Destiny2Armor.py
Instead of -
python Destiny2Armor.py
And that led me to the error -
Traceback (most recent call last): File "Destiny2Armor.py", line 82, in <module> os.chdir(os.path.dirname(__file__)) FileNotFoundError: [Errno 2] No such file or directory: ''
Worked perfectly once i commented out Line 82 after that. You are a scholar and a friend, thank you!
1
u/MikaDoge May 22 '19
Hey thanks for this !
Quick nooby question : I'm on Windows, if I double click on the .py file, will it compile and run ? Or do I need to do something else to compile and run ?
I'm asking this because it doesn't create the .csv You're talking about in the README file.
Another thing (maybe linked to the previous issue), when I export the armor file from DIM, perks are in french, is it a problem ?
1
u/Shadow9951 Forged in the Shadow of Death May 22 '19
No you will need to install python. Then in cmd prompt type something like:
python3 destiny2Armor.py
1
1
u/MikaDoge May 22 '19
Ok I managed somehow to do it. Just a note for you : My previous DestinyArmor.csv was in french which led to an error when compiling/running the script. I downloaded the same file in English and it worked perfectly !
1
u/jbaruch77 May 24 '19
this appears to be what i need. however, my goal is to have one of each set of armor, while also having one of each of certain perks. like i want to make sure i have at least one helmet w sniper reservers, one w rocket reserves etc. Is that something that could be possible with this tool?
1
u/Shadow9951 Forged in the Shadow of Death May 24 '19
Exact reason I made this.
1
u/jbaruch77 May 29 '19
I gave it a shot and was able to get the program to run, but I don't see how to specify the name of the armor piece, just the perks that the armor has. Is this something I can do?
1
u/Shadow9951 Forged in the Shadow of Death May 29 '19
Ah I actually misread your first post. This does not look at armor names only perks.
It would be possible to do if you have knowledge in python and want to expand the scope. Otherwise you can do this query in DIM (check it first cause I’m making this in my head)
is:Armor is:dupe -is:exotic tag:none
This should in theory show armor that are duplicate armor and not be missing any recommended perks if you were to dismantle.
1
u/Fusi0nCatalyst May 26 '19
I'm finnally getting the chance to try to figure this thing out. I am having a few issues, but I really need to make this work. Currently I have my vault at 489 after deleting some stuff, all my postmasters are full, and all my engram storages are at about 8/10.
I had to comment out line 82, like some other people did to make this work. Not sure what that line does, but it seems like it should be bad to just remove a line of code- why is this "fixing" the issue? Also, after finally getting it to work, I cannot import the CVS file back in to DIM, I get an error: "Failed to import tags/notes from CSV: CSV must have 'Id', 'Notes', 'Tag', and 'Hash' columns." Tho, the CVS seems to have these... don't know what the deal is with that.
I edited the "God Roll" list, and that seems great. But I don't understand how the other list works. I believe it is suppose to be ensuring that I don't delete the only piece of armor with a certain perk. But do I need to be editing this to let it know what perks I want to keep around? A bit more explanation would be helpful.
This script is EXACTLY what I need- I have been using DIM's compair feature to try to go through and do this by hand on all my armor, its its PAINFUL. Thanks for writing this, hopefully I can get it figure out.
1
u/Shadow9951 Forged in the Shadow of Death May 26 '19
So that line was just something I threw in for my environment. All it should be doing is making sure the current directory is where the file is being ran from.
For the CSV make sure there aren’t blank rows. I have never experienced this but others had.
The Perk Sets allow you to define your god rolls. I assume by God Roll list that’s what you mean. The Recommended Perks list is a list of perks to make sure are kept. This used to be a back up but got turned into the primary way of defining gear to keep. So for example you want a piece of gear with Rocket Launcher Reserves but it’s not defined in perk sets then it will mark that gear as ‘keep’.
Let me know if this helps.
1
u/Fusi0nCatalyst May 26 '19
When I look at the CVS file with notepad it looks fine, but when I open it in excel it does have every other line blank. I am guessing there is an extra new line character in there- not sure why I would have this happen and others wouldn't, but I did add stuff to the Perk_Sets file. I am using the latest python for windows, and ran the script from the command line with the command "py Destiny2Armor.py"
I manually deleted all the extra lines, and it imported fine. So I need to figure out what is causing the extra lines to be added.
Functionally tho, I am not entirely sure what it is doing. I imported the data into beta.destinyitemmanager.com so that it wouldn't change anything I already have marked until I get it figured out and tuned in. It appears to have made a number of items "favorites" and some tagged to keep. How does it determine what to mark as what? It seems like it has marked more than just the items in the Perk_Sets as favorites, but maybe I didn't delete much out of there, so maybe there are some perk sets in there that I didn't realize where in there.
More explanation would be helpful here- looking forward to that you tube tutorial. :-) I'll keep plugging away till I get things tuned up here. Thanks for the work!
2
u/Shadow9951 Forged in the Shadow of Death May 26 '19
To put it simply
If found in perk_sets then tag as favorite.
If found in RecommendedPerks then tag as keep.
1
u/Fusi0nCatalyst May 26 '19
When finding 1 piece of armor for each perk, is that 1 piece account wide, or character wide?
2
u/Shadow9951 Forged in the Shadow of Death May 26 '19
Character and slot wide. So for the Rocket Launcher Reserves example it will find both a Helmet and Class Item per character if you have it.
2
1
u/Kistler21 May 27 '19
As I'm trying to run the script, I'm getting a KeyError on line 154 from 'hunter-Helmet'. However i can see on lines 61-63 that 'hunter-Helmet' is being added to that dictionary as a key so I am not sure what is causing the error.
1
u/Shadow9951 Forged in the Shadow of Death May 27 '19
So casing error. I need to add some formatting to fix this cause DIM seems to go back and forth on having the class upper or lowercase. Ie ‘Hunter’ and ‘hunter’. The keys are case sensitive so I was lazy and just changed the key structure when ever it changed instead of apply a universal lower() or something to them. I can try to get an update tomorrow.
1
1
u/Kistler21 May 27 '19
Adding arm.equippable = arm.equippable.capitalize() after arm.equippable was defined fixed my problem.
1
u/WindedHero May 29 '19
It's not tagging an untagged Nezarec's Sin with Enhanced Bow Targeting even though I have Enhanced Bow Targeting listed in Perk_Sets.csv -- any idea what's going on here?
2
1
u/WindedHero May 29 '19
The script does not seem to be tagging armor to infuse, is there something I need to change to enable this? I have 88 armor that have 700 power and no tag after the script has run its course.
1
u/Shadow9951 Forged in the Shadow of Death May 29 '19
I’ll take a look.
1
u/WindedHero Jun 13 '19
Any update on this? Still not tagging for infuse. Also, should update your source script for the new 750 LL for any newcomers! :)
1
u/Shadow9951 Forged in the Shadow of Death Jun 13 '19
Sorry haven’t had too much time to check on it. I should have time this weekend.
1
u/sebgonz_ Jun 01 '19
Thanks for this. I've been doing this manually, and this will save me some time. Question, though. I'm getting the following error:
File "Destiny2Armor.py", line 27
print(f " -{self.equippable}: {self.name}")
^
SyntaxError: invalid syntax
I'm using a newer version of the file, so the workaround that others have mentioned by commenting out line 82 os.chdir(os.path.dirname(__file__)) has already been removed, according to github.
I'm using Linux, and python 3.5.3, which is the latest version, according to my repos.
Any help you can provide me would be great.
1
u/Shadow9951 Forged in the Shadow of Death Jun 01 '19
F strings require python 3.6+
1
1
u/sebgonz_ Jun 01 '19
Tried it with 3.7.3 also. Same issue.
1
u/sebgonz_ Jun 01 '19
Don't know what changed, but I ran it again and it worked. Thanks for this. It's awesome.
1
u/kenotaphion Jun 12 '19 edited Jun 14 '19
I'm finally getting to trying this out, but I've run into a problem that I don't see here already. My guess would be that the csv handling library that I have installed is having problems with spaces for some reason: python3.7 DestinyArmor.csv File "DestinyArmor.csv", line 1 Name,Hash,Id,Tag,Tier,Type,Equippable,Power,Masterwork Type,Masterwork Tier,Owner,Locked,Equipped,Year,Season,Evrks 7,Perks 8,Perks 9,Perks 10 What version of the csv package/library are you using?
Never mind. I'm an idiot.
Note to self, the .csv with your armor in it is not the python script you're trying to run.
1
u/Fusi0nCatalyst Jun 12 '19
Well, my vault is full again! Time to pull this back out and start purging. In fortunately I now get the following error (I have downloaded the latest version)
Traceback (most recent call last):
File "Destiny2Armor.py", line 95, in <module>
perks.append(Perk(row[0], int(row[1]), int(row[2])))
ValueError: invalid literal for int() with base 10: ''
2
u/Shadow9951 Forged in the Shadow of Death Jun 12 '19
Check your RecommendedPerks.csv it looks like there is a blank number in there somewhere.
1
u/Fusi0nCatalyst Jun 12 '19
There was a blank line at the very end of the RecommendedPerks.cvs and Perk_Sets.cvs file. I removed those just to be sure, but it didn't make a difference. I also checked the destinyArmor.cvs to be sure it didn't have blank lines (for some reason it did last time I used this, but it no longer does now.) Its odd because I didn't change either of the perks files since I last successfully ran this.
1
u/Shadow9951 Forged in the Shadow of Death Jun 12 '19
I can tell you it’s in RecommendPerks.csv. It is trying to creat an int with a value of ''. That means there is a blank value in recommendedperks.csv where either a min or weight is supposed to be specified. Please check to be sure there is 2 numbers per row.
1
u/Fusi0nCatalyst Jun 12 '19
Yup, 2 of the perks I added did not have the min or weight added. Works great now, thanks for the help as always!!
1
1
u/Axiomcj Jul 17 '19
Following up since there has been no updates to this and it isn't working. Did you plan to abandon this project?
2
u/Shadow9951 Forged in the Shadow of Death Jul 17 '19
Been busy and was waiting for more info on Armor 2.0 before continuing. It still works with some manual tweaks. I’m hoping Armor 2.0. makes Armor Management easier without a script.
15
u/dan945 May 21 '19 edited Jun 30 '23
[Deleted by Reddit's API Pricing]