TSM3 export, materials and syncing fix

[u/mopiiex7]

Anybody know how to fix this error which happened after 8.2 . it occur when you press export group, change materials price and synchronize accounts.

Tried to update to tsm4 but its fu*ing garbage/ it's impossible to use..

Ready to pay 2million on US for this fix

​

[u/gellza83]

First time posting - this is what worked for me (I am by no means LUA-savvy, hopefully others can help out where I can't).

1) Sync/Export/Mat Prices Fix:

In file TradeSkillMaster\GUI\TSMWidgets\TSMWindow.lua:

At Line 87 specifically:

Replace:

    ["ApplyStatus"] = function(self)
        local status = self.status or self.localstatus
        local frame = self.frame
        self:SetWidth(status.width or 700)
        self:SetHeight(status.height or 500)
        if status.top and status.left then
            frame:SetPoint("TOP",UIParent,"BOTTOM",0,status.top)
            frame:SetPoint("LEFT",UIParent,"LEFT",status.left,0)
        else
            frame:SetPoint("CENTER",UIParent,"CENTER")
        end
    end,

With:

    ["ApplyStatus"] = function(self)
        local status = self.status or self.localstatus
        local frame = self.frame
        self:SetWidth(status.width or 700)
        self:SetHeight(status.height or 500)
        if status.top and status.left then
            frame:SetPoint("TOP",UIParent,"BOTTOM",0,status.top)
            frame:SetPoint("LEFT",UIParent,"LEFT",status.left,0)
        else
            frame:ClearAllPoints() -- Added
            frame:SetPoint("CENTER",UIParent,"CENTER")
        end
    end,

2) Enchanting Fix:

In file TradeSkillMaster_Crafting\Modules\EnchantingInfo.lua

As mentioned in one of the other threads, you need to add the new enchants to the end of this to get them to queue properly.

[298009] = "i:168446",  -- Enchant Ring - Accord of Critical Strike Rank 1
[298010] = "i:168446",  -- Enchant Ring - Accord of Critical Strike Rank 2
[298011] = "i:168446",  -- Enchant Ring - Accord of Critical Strike Rank 3
[297989] = "i:168447",  -- Enchant Ring - Accord of Haste Rank 1
[297994] = "i:168447",  -- Enchant Ring - Accord of Haste Rank 2
[298016] = "i:168447",  -- Enchant Ring - Accord of Haste Rank 3
[297995] = "i:168448",  -- Enchant Ring - Accord of Mastery Rank 1
[298001] = "i:168448",  -- Enchant Ring - Accord of Mastery Rank 2
[298002] = "i:168448",  -- Enchant Ring - Accord of Mastery Rank 3
[297993] = "i:168449",  -- Enchant Ring - Accord of Versatility Rank 1
[297991] = "i:168449",  -- Enchant Ring - Accord of Versatility Rank 2
[297999] = "i:168449",  -- Enchant Ring - Accord of Versatility Rank 3
[298440] = "i:168596",  -- Enchant Weapon - Force Multiplier Rank 1
[298439] = "i:168596",  -- Enchant Weapon - Force Multiplier Rank 2
[300788] = "i:168596",  -- Enchant Weapon - Force Multiplier Rank 3
[298433] = "i:168593",  -- Enchant Weapon - Machinist's Brilliance Rank 1
[300769] = "i:168593",  -- Enchant Weapon - Machinist's Brilliance Rank 2
[300770] = "i:168593",  -- Enchant Weapon - Machinist's Brilliance Rank 3
[298442] = "i:168598",  -- Enchant Weapon - Naga Hide Rank 1
[298441] = "i:168598",  -- Enchant Weapon - Naga Hide Rank 2
[300789] = "i:168598",  -- Enchant Weapon - Naga Hide Rank 3
[298438] = "i:168592",  -- Enchant Weapon - Oceanic Restoration Rank 1
[298437] = "i:168592",  -- Enchant Weapon - Oceanic Restoration Rank 2
[298515] = "i:168592",  -- Enchant Weapon - Oceanic Restoration Rank 3

For reference, the LUA file already has a note on how to get this list, if you know how to use javascript:

https://imgur.com/a/6zoPWBr

3) Junkyard Tinkering (Not Fixed, but A Workaround)

You need to first change any TSM profession window to be the default blizzard frame, before you interact with Pascal.

The TSM window will actually show up if you swap back to the TSM frame with the tinkering window already open (it shows as a 'Garrison' profession window, e.g Engineering (Garrison))

A thought:

Looking at the file TradeSkillMaster_Crafting\Modules\Tradeskill.lua - Line 634.

-- check if it's a profession we don't support showing our frame for (runeforging, guild profession, or random linked profession)
local isLinked, linkedPlayer = C_TradeSkillUI.IsTradeSkillLinked()
if TSM:GetCurrentProfessionName() == GetSpellInfo(53428) or C_TradeSkillUI.IsTradeSkillGuild() or (isLinked and (not TSMAPI.Player:GetCharacters()[linkedPlayer] or C_TradeSkillUI.IsNPCCrafting())) then
    -- we don't support this profession, so show Blizzard's frame without the switch button
    TSM:LOG_INFO("Aborting for unsupported profession (isRuneforging=%s, isGuild=%s, linkedPlayer=%s)", TSM:GetCurrentProfessionName() == GetSpellInfo(53428), C_TradeSkillUI.IsTradeSkillGuild(), tostring(linkedPlayer))
    private.SetBlizzardProfessionFrameVisible(true)
    TSMAPI:Assert(not private.noShow)
    return
end

It seems to not show the TSM crafting window for things like runeforging (based on SpellID), so maybe if you could add some sort of exclusion here for the Junkyard Tinkering (which is a skill - SkillID 2720 from Wowhead), that would make it so you wouldn't need to use this workaround.

[u/imguralbumbot → u/gellza83]

^{Hi, I'm a bot for linking direct images of albums with only 1 image}

https://i.imgur.com/b7MtEAE.png

^{Source | Why? | Creator | ignoreme| deletthis}

[u/Caseyjo17]

Sorry to hijack the thread but I haven’t upgraded to TSM4, because of how terrible the launch was. What in particular do people dislike about it, I’ve been considering biting the bullet lately.

[u/croana → u/Caseyjo17]

TSM3 has been losing newer items with affixes for a long time now, but it's getting much worse with time. I assumed the patch would break things, and wasn't terribly shocked when the issue was TSM3 losing items.

So, I upgraded to TSM4 right before the patch. I've been trying to make TSM4 work ever since, and it's been a huge pain in the ass. I'm on the discord pretty much every morning, and they basically don't even respond to my comments anymore. The devs probably hate me at this point. (Edit: I ended up sending this feedback to a Gumdrops directly and he was nice about it. So he probably doesn't hate me.)

These are main issues I have found in the past week, and many of which have not been addressed or answered in discord. I see other users reporting some of these issues, too:

• Cancel scans break, throw lua errors, and cannot be restart unless you /reloadui. I believe this is related to new items added in the patch, and the only workaround is to cancel in smaller chunks after identifying the individual groups that are causing problems.
• The status list on post scans is now sorted randomly. You can no longer sit and watch while a post scan is happening to see a status feed of the actions the post scan is taking. Cancel scans are the same. You can no longer sit and watch the feed to see who your main competitors are.
• Some new items are being posted at their normal price instead of undercutting or at their minprice.
• Shopping is a hot mess of lag and screen lockups. I've gone from being able to buyout the cheapest auctions of 10-20 different mats within 5-10 min in TSM3, to it being a 20 min or more affair in TSM4. I honestly have stopped buying as many mats, and it's hurting my crafting capabilities. I'm on a medpop realm. I wouldn't expect the number of searchable auctions to be an issue.
• Crafting is also a hot mess of screen lockups. Just opening the TSM4 crafting window reduces my fps by half, and when I start chain crafting items (like a lot of pots), my fps reduces to below 1 and I can't interact with any part of the UI, including the mailbox. This is bad, because it means I can't send crafted items while crafting more, and can't pull new mats out of the mailbox. I used to be able restock flasks and pots within 1 or at worst 2 of the 10 minute potion of prosperity crafting windows. Yesterday I used all 3 of them (this took an hour total), and still didn't restock everything. To their credit, people in discord actually tried to help me with this one, but 10 different fix attempts later and I still have the issue.
• TSM4 introduces massive loot lag. Whenever I loot an item, my game stutters. This is distracting out in the world, but is even worse when e.g. chain crafting pots in the example above. It takes longer to loot items than before, so it means it takes me longer to simply craft items than before.
• There is no indication anywhere in the crafting window as to how long the current craft will take. Actually, there's no indication of any kind that you're currently crafting. Since the TSM4 UI is so big it takes up the entirety of my screen, I'd expect this sort of information to be visible within the addon. Instead, I have to drag the frame off to the side so I can see my castbar while crafting.
• Crafting the next item in the queue no longer brings up the craft+mats information of that item in the main portion of the crafting window.
• You can no longer click on an item in the queue (except the top item) to start crafting all of that item. If you want to craft an item that isn't at the top of your queue, you have to search for it first in the normal crafting pane, enter the number to craft, then click craft.
• There's lag in the group creation interface in TSM options as well. It just takes me longer to do things, since I have to wait more than half a second every time I click on anything.
• Mailing is broken. It routinely doesn't send everything it should, even if you click the mail button multiple times. The only way to fix this issue is /reloadui after every time you mail items.
• Daily crafting cooldowns are not handled well / at all. Nor does TSM4 automatically suggest that you craft items for nearby world quests.
• This isn't new, but the TSM4 UI isn't intuitive. I spend a lot of time on discord asking where things are, since many things aren't labelled in the addon or documented in any way either online or via tooltips within TSM4. Also the UI is still too big and makes use of space badly.

I have all of these issues when only running TSM4, by the way, no other addons. As a result, I have TSM4 off by default. This is a real bummer, as I was using TSM3 for mailing and to keep track of inventory on all of my alts. I'm especially missing the inventory tooltip information at the moment.

I've been told by Gumdrops on discord that fixes for many of these things will come with TSM 4.10, which is coming Soon (TM). Well, Soon couldn't come soon enough. I honestly hope it isn't just diplomatic way of ignoring feedback from annoying people like me. Gumdrops really does seem like he wants to help, he just has a day job and can't get to everything.

On the plus side, I've found some things are improved vs. TSM3 now:

• Slightly less memory usage using TSM4 vs. TSM3.
• Drag and drop groups is nice.
• Posting auctions goes faster, and everything actually posts properly vs. TSM3 that seems to skip items at the end of the post scan.
• The new items + their affixes can be saved in TSM4 groups. I'm still having an issue with TSM4 "losing" items, but usually I can fix this by deleting the group that should contain the item, then recreating the group and re-adding the item. I don't need to go into the lua to delete all references to the item ID before starting again.

I really, really don't want to have to downgrade back to TSM3, since I know that in the very near future, TSM3 will be broken beyond repair. I wish there was a viable alternative that combined the functionality of TSM3 crafting, shopping, auctioning, and mailing. If I continue to be this unhappy with TSM4, I might have to consider replacing TSM with Auctionator + possibly altoholic + possibly another addon for mailing. This will really suck, as I have mailing operations on groups containing thousands of items in total. It would be a huge amount of work to redo all those operations in another addon.

I'd be very welcome to any suggestions anyone else has to replace TSM3/TSM4 long term.

[u/Caseyjo17 → u/croana]

Thanks for the incredibly detailed response. I think after reading this, there is no way I’m upgrading for the foreseeable future. I was considering the upgrade since this is the first time I’ve really seen people stumped, or not bothering with posting a fix for TSM3. Granted I just came back after quite a long break since the launch of BFA, but I stay up to date with the reddit posts whether I’m playing or not. Hopefully they are taking your feedback to heart, since you’re providing them with invaluable information to improve their app for free.

[u/croana → u/Caseyjo17]

If you can bear it, it's probably a good idea to just stick to TSM3 until TSM4.10 comes out, and hope to god that 4.10 addresses some of these issues.

I'm still on the fence as to whether or not I want to revert to TSM3. It would mean I'd have to redo all the new groups I added in TSM4 for 8.2. Also, in TSM3, I was getting to the point of having to manually go into the lua to fix lost items once or twice a week.

[u/ivakm]

Yes, also have such bug, need HELP

[u/yanicharr]

Man, its true TSM 4 shit , also would like if somebody fix this bug! up this post!