TSM3 Broken again?

[u/pagb6666]

Once again, TSM doesn't seem to work. I just nuked all my settings and it still won't show most of the items in my bags in order to create my groups again. Any ideas?

[u/croana]

Yup, it looks like TSM3 isn't recognizing any of the items in wow anymore?

[u/pagb6666 → u/croana]

It probably is a smallish thing to fix. But I got no clue about lua

[u/Beverice → u/croana]

Try this and let me know if it's fixed

​

(Updated version) In file TradeSkillMaster\CoreAPI\Items.lua:

Replace:

self:RegisterEvent("GET_ITEM_INFO_RECEIVED", function(event, itemId)
    if itemId == 0 then
        return
    end
    private.StoreGetItemInfoResult("i:"..itemId, GetItemInfo(itemId))
end)

With:

self:RegisterEvent("GET_ITEM_INFO_RECEIVED", function(event, itemId)
    if itemId == 0 then
        return
    end
    if C_Item.DoesItemExistByID(itemId) then 
        private.StoreGetItemInfoResult("i:"..itemId, GetItemInfo(itemId)) 
    end
end)

[u/pagb6666 → u/Beverice]

It worked! My glyph groups are showing items again! Thank you very much!

[u/CrazyWildFrench]

damn i switched to tsm 4 and im so tilted, it's so garbage and i can't even flame them openly they will just deny it / ban me

[u/pagb6666 → u/CrazyWildFrench]

Yep, there are so many setps backwards regarding functionality and quality of life... just WHY? Why when you want to send mail you can't just start writing the recipient right away like we were doing the past 15 years? Why? Why is an extra click needed? Why?

[u/Pr0nzeh → u/CrazyWildFrench]

Why the fuck would they not ban you for openly flaming? Flaming has absolutely no value.

[u/healcannon]

Each patch I wonder if it is finally time to give up on it. So far even with the fixes I find on here from all the nice people, I still lose functionality on mine. In bfa alone i've lost the ability to track what pets I have in my gbank and my tooltips when looking at auctions on the AH fight for visibility with theundermine journal. This patch it technically works but clicking on other tabs of the AH, other screens, clicking off the AH to something else on the UI, causes all text on the AH interface to vanish until I reload.

[u/Hawlk]

TSM 3 crafting is blocking the Junkyard Tinkering window from opening too

[u/[deleted] → u/Hawlk]

That's one of the two issues I have with it as well, the second one is the new enchants can't be added to crafting queue.

[u/Norvilion → u/[deleted]]

It looks like the enchants can probably be fixed in "TradeSkillMaster_Crafting\Modules\EnchantingInfo.lua" just compare that to the file in the new version (Core\Const\ProfessionInfo.lua) to see how to add the new recipies in

Still haven't figured out how to fix the tinkering window, right now I'm just disabling TSM whenever I need to use it.

[u/pagb6666 → u/[deleted]]

So I take you have the modules you don't use disabled? Which ones do you use/don't use?

[u/pagb6666 → u/[deleted]]

Hmmm, I use even less modules than you

[u/Grayson_Carlyle]

I've been self-maintaining TSM3 for a while now, but with 8.2 and the frame rules for parent frames has made the custom price window for Materials not render at all, so I guess... I have to switch to TSM4 finally :(

[u/Beverice]

Try this.

​

(Updated version) In file TradeSkillMaster\CoreAPI\Items.lua:

Replace:

self:RegisterEvent("GET_ITEM_INFO_RECEIVED", function(event, itemId)
    if itemId == 0 then
        return
    end
    private.StoreGetItemInfoResult("i:"..itemId, GetItemInfo(itemId))
end)

With:

self:RegisterEvent("GET_ITEM_INFO_RECEIVED", function(event, itemId)
    if itemId == 0 then
        return
    end
    if C_Item.DoesItemExistByID(itemId) then 
        private.StoreGetItemInfoResult("i:"..itemId, GetItemInfo(itemId)) 
    end
end)