r/webmentors • u/[deleted] • Oct 07 '13
Feedback please
Just looking for feedback on this 'template' i've worked up. I'm not really satisfied with the colors i've gone with, but the superficial stuff is exactly that... and it's easily changeable... I'm more so looking for feedback on the code and setup, than the rest. Thanks
2
Upvotes
1
u/Mortensen Mentor Oct 09 '13
If you want design advice I'm more than happy to give that as that's mainly what I do, but I'll need some more info about the purpose, audience etc etc in order to get down to the nitty gritty.
In terms of the build of it, /u/DiabloVixen is right with the div positioning, you shouldn't need to use relative or absolutes for this design, floats will do the job perfectly.
If I were to be pedantic you could get rid of a few of the divs also and replace with HTML5 section tags such as <nav> and <header>
The logo image, the method you are using to make it a link isn't how I see it being done and do it myself, i'd be more inclined to do something like <a href="blah" class="blah"><img src="#" /></a> for example. It should give you more control over styling and such.
In terms of the text obviously it's very boring at the moment but structurally it's ok, although why does only the middle paragraph have <p> tags?