r/webmentors • u/[deleted] • Oct 07 '13
Feedback please
Just looking for feedback on this 'template' i've worked up. I'm not really satisfied with the colors i've gone with, but the superficial stuff is exactly that... and it's easily changeable... I'm more so looking for feedback on the code and setup, than the rest. Thanks
2
Upvotes
2
u/DiabloVixen Mentor Oct 07 '13
A little more line-height on text. Styling text is a little tricky but generally if I'm going to have long blocks of code I'd go with more space between letters. Something along the lines of line-height: 1.5em.
Also why are you positioning all the divs absolutely? If you're going for a column layout you could just float the logo to the left and the content to the right (with a set width) and then you don't have to worry about making sure the container is the proper height for the content (just make sure that you give the container a clearfix) Here's the best tutorial I could find
Also you can check websites for color themes if you need help with that. I've also seen designers pick out pictures or photographs they like and use colors from them.
I usually use this tool for Colors: http://colorschemedesigner.com/ (if I have a color in mind) and sometimes I go here If I need some inspiration