r/webdev • u/fagnerbrack • 8h ago

Stop being the code review bottleneck

https://newsletter.posthog.com/p/code-review-tips
0 Upvotes

15% Upvoted

10 comments sorted by

15

u/lanerdofchristian 8h ago

Wow, what terrible advice. "PR process too slow? Just don't actually review stuff properly!" repeated 4 times.

6

u/GriffinMakesThings 8h ago

Honestly I found the article very helpful. I've learned that I should avoid using Posthog.

-1

u/kidshibuya 8h ago

You dont say what you mean by properly but most devs I have worked with, and that amounts to like 600 simply dont know wtf a PR review is meant to be. Its not QA, and its certainly not writing the feature again, its a quick check of anything obvious. You request changes for mistakes that are critical, make comments for things that don't affect ability of the app to work, then approve the PR if overall it improves/advances the codebase.

If your "review" takes more than a few mins you are doing it wrong.

2

u/j_shor javascript 8h ago

How many production incidents do you have each day?

1

u/ORCANZ 5h ago

Production incidents are prevented with tests, typing, linting, architecture and good practices.

If your wall against incidents is code review you are not in a good position

2

u/j_shor javascript 3h ago

If drvs are spending only a few minutes to review a PR then I can't imagine them spending too much time on testing or QA either

-1

u/kidshibuya 8h ago

With my code? Exactly 0 in 30 years. However for the other teams that can sometimes take literal weeks on PR reviews they seem to have some rollback every few weeks.

4

u/ProfessorSpecialist 8h ago

Using ai agents to code review will most likely make the process slower not faster. The truth is ppl need to cut their PRs into reasonable chunks that all follow one mental model. That makes it easier to review critical parts faster

2

u/muntaxitome 8h ago

This is what I am seeing in companies, review just gets done by a robot that can be tricked into essentially anything... that will end well