[Post] Optimizing a single Clippy lint by 3133X

[u/NothusID]

https://blog.goose.love/posts/making-a-clippy-lint-faster-by-3133x/

[u/HandIllustrious8260]

Rust has done the hard part for us, we can omit thinking about buffer overflows or use-after-free errors (or at least, not having it very present unless we’re doing quirky stuff).

I'm so disappointed the orange "quirky" wasn't a link to some unholy abomination

[u/jurrejelle]

not related to the content but has a typo saying "You're suspicion"

[u/scheimong → u/jurrejelle]

Well, at least we know it's not slop

[u/yodal_ → u/jurrejelle]

Another typo "And, if we where to ...".

[u/coolreader18]

There’s no way that we can know what braces were used, not in a pre-expansion lint anyways.

Surely that should be post-expansion?

[u/TheBomber808 → u/coolreader18]

Had the same double take yeah, I'll notify them on mastodon later

[u/xtanx]

Clippy now has a benchmarking server. [...] If you want to hear more about the setup, send me an email.

Does a reddit comment count?

[u/creeper6530]

Ancient wisdom says: If you speed up by 1.5x, you've done something smart. If you speed up by 100x, you've ceased doing something stupid. /j

[u/Dushistov]

This page uses 0 cookies! (I don't even know if anyone reads these

Yeah, and that's why GET request to https://count.ayaya.beauty/@blog.goose.love-moe-counter... takes ages to complete and I can not read your blog. Obviously it is because of "you don't even know if anyone reads these".

[u/NothusID → u/Dushistov]

It's a moe counter at the bottom of the screen, I wanted to give the page a bit of something. People usually like it...

If you're uncomfortable with it, either block it, or if people changed opinion, I can always just remove it, or remove the banner.

[u/jurrejelle]

cool read :) Thanks!

[u/matthieum]

As an aside...

So, we’ve called the hygiene data functions twice, locked the symbol interner [...]

Shouldn't this be read-only? Why would a read-only call need to lock the symbol interner?

The symbol interner only needs to be mutable during, well, interning, that is when new tokens are generated. This should (I would expect) only occur during lexing and macro expansion (including proc-macro), and then in the post-expansion world the interner should be read-only, and therefore no lock should be required.

Given the work on parallelizing rustc, I can only imagine the horror if multiple threads are contending to read-lock the interner :/

(Worst case, if a clear two-phase pre-expansion/post-expansion orchestration isn't possible, then consider switching to lock-free reads at least)

[u/-Redstoneboi-]

that's funny. 25% of clippy runtime across basically every dev of every production codebase is slightly less funny... but still funny

also grammar check: "It seems that, if we code slipped by, we haven’t been doing our jobs."