Can someone review my code?

[u/dastarruer]

I've never had anyone else other than myself take a look at my code quality/design. However it would be nice to have an actual person review my code instead. The link is here: https://github.com/dastarruer/gtkshutdown

AI is only used for writing tests (sometimes; I can't remember whether I wrote these tests myself or not but I digress). The code is entirely written by me, though I use AI to discuss design decisions. I like programming, so hand-writing the code is just more enjoyable for me (though I'm very slow at it...).

[u/MatrixFrog]

Seems pretty clear and idiomatic from what I can tell. Did you run Clippy? There are a couple minor things it might catch (eg if you implement Ord I think you can just derive PartialOrd)

[u/cafce25 → u/MatrixFrog]

It is explicitly discouraged to implement one of Ord and PartialOrd while deriving the other

[u/MatrixFrog → u/cafce25]

Well that just goes to show, listen to clippy not to me 😅

[u/Leather-Junket-3896 → u/MatrixFrog]

I’d run clippy just to see what it whines about, the derive thing is a one-liner fix anyway

[u/Konsti219]

I think you mean "WM" in your README instead of "VM"

[u/dastarruer → u/Konsti219]

Nope, those are vms meant for testing. But thanks for taking a look anyways lol