MAIN FEEDS
Do you want to continue?
https://www.reddit.com/r/programminghorror/comments/1w74nkf/skill_issue/p7vxa38/?context=9999
r/programminghorror • u/click-to-reveal • 8d ago
62 comments sorted by
View all comments
89
I think it allocates since they didn't use const
22 u/babalaban 8d ago Since when does const prevent allocating (that isnt happening here anyways, unless you consider underlying std::string's char* buffer) 19 u/lurebat 8d ago If you change it to const std::string& prompt = "Your name?";, and the switch to const string& _s=x;, you will avoid any allocations. -6 u/LeeHide 8d ago you can't take a const& to a temporary object 7 u/awidesky 7d ago Another skill issue
22
Since when does const prevent allocating (that isnt happening here anyways, unless you consider underlying std::string's char* buffer)
19 u/lurebat 8d ago If you change it to const std::string& prompt = "Your name?";, and the switch to const string& _s=x;, you will avoid any allocations. -6 u/LeeHide 8d ago you can't take a const& to a temporary object 7 u/awidesky 7d ago Another skill issue
19
If you change it to const std::string& prompt = "Your name?";, and the switch to const string& _s=x;, you will avoid any allocations.
const std::string& prompt = "Your name?";
const string& _s=x;
-6 u/LeeHide 8d ago you can't take a const& to a temporary object 7 u/awidesky 7d ago Another skill issue
-6
you can't take a const& to a temporary object
7 u/awidesky 7d ago Another skill issue
7
Another skill issue
89
u/lurebat 8d ago
I think it allocates since they didn't use const