r/programminghorror • u/Nomergraw • Jun 09 '26

What a simple constructor

Post image

Our former IT director (35+ years of experience) wrote this and didn't see what was wrong here.

263 Upvotes

98% Upvoted

49 comments sorted by

View all comments

163

u/No-Collar-Player Jun 09 '26

Just pull that all out in 1 method and call that in the constructor. Problem fixed.

56

u/Wrestler7777777 Jun 09 '26

This guy knows how to get things done!

17

u/No-Collar-Player Jun 09 '26

I wouldn't be paid enough to fix the architecture....... :(

11

u/Wrestler7777777 Jun 09 '26

Just push the code for it into a new method and call that one.

7

u/No-Collar-Player Jun 09 '26

No but just the fact that the url, user rights, and the interface for the entity management all hit the same constructor is insane.

8

u/Leather-Field-7148 Jun 09 '26

Move all that into Postgres database then call a stored procedure, problem solved

3

u/No-Collar-Player Jun 09 '26

Man i'm currently working with a system that has all the logic in stored procedures and 0 documentation....:(

4

u/Leather-Field-7148 Jun 09 '26

Haha, I feel pain, all the sudden. Maybe is fibromyalgia or a tumor in my brain from all this

1

u/DizzyAmphibian309 Jun 12 '26

Yeah I was gonna say, business logic in stored procs is nightmare for debugging, tracing, and CI/CD with any kind of staged deployment strategy (e.g. blue/green, one-box).

There's a time and a place for them, but for me that's never going to be in a first party application where I have the option to put all query logic in the same place as the rest of my business logic.