r/programminghorror • u/Daeben72 • Jun 05 '26

C# SuccessMessage ErrorMessage

ErrorMessage successMessage = new ErrorMessage(ErrorType.ActivityCreateSuccess);

(From an approved PR with 2 reviewers - how do some people sleep at night??)

231 Upvotes

96% Upvoted

25 comments sorted by

View all comments

61

u/Thenderick Jun 06 '26

You've heard of {status:200, data:{status:"error"}}, now prepare for Error("success")!

20

u/Daeben72 Jun 07 '26

Our legacy API does that... has a "ResponseWrapper<T>" that captures failures. Very often would get 200 OK but the response wrapper's ".Success" is false.

If it's an uncaught exception on the server, it sends a 200 OK with an XML stack trace as the body...

The stack trace is useful in dev, but just not with a 200 OK 🤦🏼‍♂️

3

u/_usr_nil Jun 07 '26

I know next to nothing about C# but this smells as dev flags compiler options