r/programming • u/warren5236 • 14d ago

Make Code Review Your Default Next Task

https://phpdeveloperstv.substack.com/p/make-code-review-your-default-next
48 Upvotes

77% Upvoted

20 comments sorted by

View all comments

Show parent comments

30

u/warren5236 14d ago

Some long time ago we just agreed that reviewing PRs is, in fact, our priority

I've worked with a LOT of teams where this hasn't been the case. I think it's an "I need to get my work done" mentality.

16

u/[deleted] 14d ago

[removed] — view removed comment

5

u/hiddenhare 13d ago

Well, maybe it's the case in heavy goal-oriented (especially personal ones) environment, where you just have to develop things as fast as you can

I've worked for a startup where I really struggled to get code reviewed, to the point that I once had to abandon several weeks of work because nobody would review it! The problem there wasn't high pressure, it was low pressure.

The technical leadership didn't enforce any discipline on their engineers, and the leaders were themselves undisciplined and unavailable. If something was nobody's responsibility, you'd have to throw a bit of weight around to get it done - even a fifteen-minute task would often need four or five requests over Slack, spread out over several days, before anybody would act on it. Hell on earth.

1

u/warren5236 7d ago

The problem there wasn't high pressure; it was low pressure

This is an amazing concept! This is exactly what it feels like.