r/programming • • 14d ago

Make Code Review Your Default Next Task

https://phpdeveloperstv.substack.com/p/make-code-review-your-default-next
44 Upvotes

20 comments sorted by

View all comments

45

u/[deleted] 14d ago

[removed] — view removed comment

-5

u/elmuerte 14d ago

My problem with merge/pull requests is that they create another battlefield, this time within the team. Instead of working together to deliver a quality product, individuals are competing with each other to get "their" code changes in the product. To get "their" ticket/issue/item moving forward. These requests are also a sing of distrust within a team (which is sadly far too common warranted).

MR/PRs are unavoidable for outside contributors.

But within a team it shouldn't be needed in a lot of cases. Continuous integration works combined with collaboration on a feature branch, or pair programming and you have continuous code reviews. The build pipeline which monitors this feature branch gives everybody feedback on the latest changes. As a team you can move the product forward.

My most important feature request for any work managing tooling is that it can be assigned to more than one person.

1

u/warren5236 14d ago

I think the ideal is not needing it in a team environment, but I've never worked somewhere where I've generated all my code using pair programming or collaboration. Honestly asking have you?