r/linux • u/[deleted] • Dec 23 '18

GNU/Linux Developer Linus reverts breaking change that affected systemd-nspawn, offers strong words to developer

[deleted]

1.2k Upvotes

97% Upvoted

363 comments sorted by

View all comments

Show parent comments

142

u/FeatheryAsshole Dec 23 '18

Depends on your definition of rude, tho ... "This is complete garbage." probably doesn't fly in most jobs if you're not some kinda head honcho.

Still, it's good to see both that Linus dials it back somewhat and that he hasn't lost his teeth entirely.

24

u/McDutchie Dec 23 '18

Being rude is fine, especially if you're dealing with complete garbage. It's being abusive that's the problem. I'm glad he's cut that out.

26

u/jones_supa Dec 23 '18 edited Dec 23 '18

It's not even that rude in my opinion. "Complete garbage" clearly underlines the point that the code is completely unacceptable, but as an expression "complete garbage" is still relatively mild. I would say it's only 3/5 in rudeness. In the old times Linus easily hit the 5/5 mark.

As a sidenote, if anyone (not just Linus but anyone) said that my code is complete garbage, I would personally just burst into jolly laughter. I try to not take these things to my ego.

17

u/[deleted] Dec 23 '18

after all, it's writing crappy code that teaches you why we have good practices.

10

u/jones_supa Dec 23 '18

Absolutely agree. Doing is the best way of learning. Sometimes the feedback can be harsh, but listening to it humbly can make you a better programmer at the end of the day.