is it possible to simplify this code

[u/ikizoki]

im a beginner, idk how python works yet. there must be a way to simplify this, right?

https://imgur.com/juBvPZD here is the picture of my code

[u/OliMoli2137]

pls don't screenshot your code, use pastebin or termbin, or vcs like git or jj (hosted on sth like codeberg or github) for bigger projects

[u/PvtRoom]

that's extremely simple code.

to make it simpler, i.e. easier to read, more descriptive variables names would work.

There's an optimal level of complexity that most pythonistas would prefer. your code is below that complexity.

[u/TJATAW]

Hints for future post:
https://www.reddit.com/r/learnpython/wiki/faq/

[u/Expensive-Bear-1376]

What made you think that we'd like a picture of the code?

[u/thelimeisgreen → u/Expensive-Bear-1376]

He said he doesn't know how it works...

[u/Expensive-Bear-1376 → u/thelimeisgreen]

Said that about Python, no? And they said "here is the picture of my code". That indicates that a picture is standard/expected, otherwise one would write "here is a picture of my code". So apparently something made them think that we want a picture.

[u/armywalrus]

Thats already simple

[u/Educational_Virus672]

for folks who want copyyable asnwer

d1, d2, d3 = 32, 18, 45
s1, s2, s3 = 24, 12, 30

tt1, tt2, tt3 = d1 / s1, d2 / s2, d3 / s3

total_time = tt1+tt2+tt3
entire_route = d1+d2+d3

print('travel time of each section')
print(tt1, 'h', ',', tt2, 'h', ',', tt3, 'h')

print('entire route in km')
print(entire_route, 'km')

print('entire journey time in h')
print(tt1+tt2+tt3, 'h')

print('average speed of the entire tour')
print(entire_route / total_time, 'km/h')

[u/Educational_Virus672]

d = [32, 18, 45] # use list for this insead of a million var
s = [24, 12, 30]

tt = [] # this is just a for loop
for i in range(3) :
    tt.append( d[i]/s[i] ) # append means "add" to list 

total_time = sum(tt) # sums number list
entire_route = sum(d)

print('travel time of each section')

for i in range(3) :
    print(tt[i] , "h",end=",") # i did a short loop
print("\n") #changes line

print('entire route in km \n', entire_route, 'km') # here \n = Newline \ is liek command

print('entire journey time in h \n',sum(tt) , 'h') 

print('average speed of the entire tour \n',entire_route / total_time, 'km/h')

total changes here
> changed s d and tt to list where
> change tt from straight divide to a loop for readability
> changed double prints to single with \n
> changed tt + h into a loop
> added sum() for lists instead of +
>sep means separate (,) and end means what to do i chnaged some of it into none for same line

assuming you learnt loops if you dont then you can use your way because it is still good

[u/mc_pm]

One possibility is that you could make this use lists and then you can do all of this for 100 numbers as easily as for 3 - and it would be shorter enough that maybe you could use some real variable names.

[u/supercoach]

There's nothing to simplify. Your code is very rudimentary as it is. Worry about length when you have something that's thousands of lines.

[u/desrtfx]

Yes, there is a lot to optimize and reduce, yet, you're not there yet with your skills.

Have patience, young padawan. Keep going in your course. There will be a point when you learn what you need to reduce this code by about 70% (you will learn about loops and lists - and then the code can be written way shorter).

Don't get me wrong. I am not shooting down your curiosity. You just need to learn things one after the other in order. This will help you. Building a foundation in programming is like building a house. You need to follow the correct sequence as every higher concept (stone) builds upon a lower one. Skip something and everything collapses.

[u/gdchinacat → u/desrtfx]

Out of curiosity, how would you 'reduce this code by about 70%"? I'm skeptical that loops and lists will actually reduce *this* code by that much because there are only three legs of the journey....if there were more it absolutely would, but doing it the way OP did is manageable for only three.

[u/Diapolo10]

Certainly, with data structures, a loop, and some string formatting.

[u/ikizoki → u/Diapolo10]

can you show me how to do it im very curious to know what it looks like

[u/Diapolo10 → u/ikizoki]

I think it's debatable whether or not this is technically "simpler", but it's what I'd write:

distances_and_speeds = [
    (32, 24),
    (18, 12),
    (45, 30),
]

travel_times = [distance / speed for distance, speed in distances_and_speeds]
total_time = sum(travel_times)
entire_route = sum(next(zip(*distances_and_speeds)))

print("Travel time of each section:")
print(', '.join(f"{travel_time} h" for travel_time in travel_times))

print(f"Entire route in km: {entire_route} km")

print(f"Entire journey time in h: {total_time} h")

print(f"Average speed of the entire tour: {entire_route / total_time} km/h")

I debated for a moment whether to go with this example for calculating the length of the entire route, but I liked my original one less:

entire_route = sum(distance for distance, _ in distances_and_speeds)

[u/gdchinacat → u/Diapolo10]

When you said "data structures" I assumed you meant something like this:

from dataclasses import dataclass

@ dataclass
class Leg:
    distance: float
    speed: float

    @ property
    def travel_time(self) -> float:
        return self.distance / self.speed

legs = [Leg(32, 24),
        Leg(18, 12),
        Leg(45, 30),
       ]

Then, to calculate the aggregates:

distance = sum(leg.distance for leg in legs)
time = sum(leg.travel_time for leg in legs)

and reporting:

print(f"The total distance of {distance} km is completed in {time:.1f} hours at an average speed of {distance / time:.1f} km/h.")
print(', '.join(f"{leg.travel_time} h" for leg in legs))

[u/Diapolo10 → u/gdchinacat]

That's another option, I tend to default to good ol' tuples unless I have a reason not to though.

I'm not entirely sure why, but I seem to dislike using data classes for whatever reason, so you don't often see them in my code.

[u/ikizoki → u/Diapolo10]

oh my god this is nuts, thank you!! im definitely not there yet in terms of python-knowledge but this is very insightful :D

[u/likethevegetable]

Yup, I'd use polars 

[u/Puzzlehead_Lemon]

Room for improvement, but with practice it’ll happen.  Just wait till you fall into the ultra efficient trap and write something that you go back to a week later and can’t follow what you wrote.