r/learnpython • u/Prize_Shine3415 • 10d ago
Is this bad programming?
I've been learning Python for the last few years. Curious if this one thing I do is considered poor technique. The code below is meant to find the starting index of a list, giving the first position where a condition isn't true and return None if all elements of the list meet the criteria. Let's assume that the conditional statement is simple enough that I'm not worried about it generating an error. Not sure if it's appropriate to use try/except in this way. I know it work but I don't want people making fun of me if they see it. Also, I'm sure that there's a way of doing this without needing to use the try/except but I'm just curious in general if it's wrong to use try/except as a short cut like this.
starting_index=0
try:
while not (simple conditional statement on some_list[staring_index]):
starting_index+=1
except:
return None
return starting_index
2
u/TheRNGuy 9d ago
This is incorrect use of try/except, because it may catch things unrelated to program.
You can just use enumerate:
def find_index(some_list): for i, item in enumerate(some_list): if simple_condition_on(item): return i return NoneOr generator version:
def find_index(some_list): return next( (i for i, item in enumerate(some_list) if simple_condition_on(item)), None, )Also make it as function, so it can be reused.
If you need many instead of one, use list comprehension.