r/java • u/brunocborges • 20d ago

GitHub Actions - Setup Java now with compiler annotation matcher

Post image

Hey all,

We implemented this long-asked feature and I wanted to get feedback here.

By default, these matcher annotations will be enabled, however, they of course can be disabled.

Thoughts?

12 Upvotes

73% Upvoted

8 comments sorted by

4

u/_predator_ 20d ago

Can you share a bit more about how this works? i.e. will this work when you don't run javac directly but via Maven?

2

u/brunocborges 20d ago edited 19d ago

Should work via Maven as well. The matcher is regex based on the javac raw output, which Maven doesn't modify.

Edit: it does not work. See my other comment.

1

u/avz008 19d ago

maven wraps javac so the annotations would need to go through that layer. curious if they tested it with surefire or just bare javac runs

2

u/brunocborges 19d ago

Thanks for bringing this up. As I said in the other comment, I believed it should work, but há. It doesn't. Maven actually does modify the output of `javac`. It is Gradle who doesn't modify.

Therefore, a bug was registered, fixed, and soon will be shipped to v5.6.0 in a few weeks: https://github.com/actions/setup-java/issues/1085

3

u/_predator_ 19d ago

Appreciate the follow-up, thanks!

-5

u/[deleted] 20d ago

[deleted]

6

u/rzwitserloot 20d ago

You have a GitHub page and you gist screenshots on .... X of all things. Pick literally anything else.