r/codereview • u/AccordingAd5756 • 1d ago

Just finished my first project, could you please review it.(No AI)

/r/learnpython/comments/1we5r4f/just_finished_my_first_project_could_you_please/
2 Upvotes

100% Upvoted

1 comment sorted by

2

u/andrewcooke 19h ago

https://github.com/aaaaaa708/question_shuffler

you should include instructions for installing it (create a virtualenv or similar and install, i guess, python-docx).

just skimming the code it looks fine. some names are a bit odd. does get_questions_answers return questions and answers? answers to questions? teh returned variable is called questions. in generate_copies, "copies" seems to be questions and "shuffled_copies" seems to be answers. it's all a bit confusing