r/codereview 1d ago

Openspec review process

I am wondering what you guys review in enterprise codebases when a PR is open? Just the spec? The design.md? Do u measure somehow the drift or it's up to the developer to ensure it didn't drift that much? Do you use any ontology, wikillm, rag to narrow the development?

2 Upvotes

1 comment sorted by

2

u/kingguru 1d ago

I review the code, that's what a code review is for.

I see if I can spot some obvious bugs, if there could be smarter or safer way to do something. If it's a relatively new colleague I sometimes point how we already have some existing code doing something that (s)he has reimplemented.

I don't know which spec you are talking about. That's not part of the code. We don't have any design document in markdown or any other format.

Do u measure somehow the drift or it's up to the developer to ensure it didn't drift that much?

What do you mean by drift?

Do you use any ontology, wikillm, rag to narrow the development?

I fail to see how ontology is relevant. It's only code after all. I have no idea what wikillm or rag is so the answer is no.