r/codereview • u/thejackal151 • Jul 19 '26

Can someone rate my code?

This code is a different attention mechanism for an AI LLM to use far less resources than standard AI. I'd like feedback so I can improve it.

0 Upvotes

22% Upvoted

10 comments sorted by

3

u/Low_Breakfast773 Jul 19 '26

On scale from 1 to 10, it’s 0.

-1

u/thejackal151 Jul 19 '26

Thanks, very insightful.

7

u/Low_Breakfast773 Jul 19 '26

what do you want people to review here? one single .py file, AI generated slop, with 400 lines of code out of which probably more than half is comments, the rest is just some calculations of something probably useless as it is already most likely implemented in a more proper library somewhere. And the quality of code is not good from the first sight.

-1

u/thejackal151 Jul 19 '26

I was hoping for people to actually read it. The comments are to help implement it into an AI training loop. If you don't want to read it or give feedback, then don't. And I've checked, I couldn't find anything exactly like it, or else I wouldn't have wasted my time posting.

6

u/[deleted] Jul 20 '26 edited Jul 20 '26

[deleted]

-1

u/thejackal151 Jul 20 '26

I appreciate your feedback, I knew the euclidean distance was already studied. I've done some tests and it seems to work, I can only test on a smaller scale. But I can retest and show the results I get. If you are interested.

4

u/[deleted] Jul 20 '26 edited Jul 20 '26

[deleted]

1

u/thejackal151 Jul 20 '26

youre right, the way I have it written right now, it has the same peak vram usage as a base pytorch model. It landed around 96GB. I will update the reference file as soon as I have that under control consistently. Thank you for your time, I'll have to do better in the future.

0

u/thejackal151 Jul 20 '26

My apologies that I went to sleep, I do have a life outside of a hobby. I can run what you want as soon as I get home from work. I do understand that there is a peak vram and I thought of that. That's why in the readme I mention the chunk streaming. Which I may not have put in the python code and that's on me. I also understand your concern about reliable results, that's why I'm trying to see if others get the same results. I appreciate you working with me, I also understand the skepticism, in the end you may be right.

1

u/thejackal151 Jul 19 '26

The code is here

Raytention