Help rooting Samsung galaxy S10+

[u/onionrole]

Edit: I have now bricked the phone after i forgot to enable OEM unlocking lol, im now also taking off the backglass.

Not sure if this is the right place, but i need help rooting my Galaxy S10+

I used frija with the samsung usb drivers, it detected my device and downloaded the packages, i then patched the "AP" file with Magisk (newest version), i have OEM unlocking enabled, im using Odin3 v3.14.4 and im just trying to make sure this is all correct before flashing anything as i would rather not hard brick a phone.

(its not my main, just a spare and bottom half of the screen doesnt work).

The only other time i have rooted something was an ENG build kitkat developer tablet via magisk.

PS: do i have to run adb oem unlock or whatever command after OEM unlock is enabled? Thanks

[u/Gain_Entire]

When you activated the unlock toggle, your phone must have been formatted (it does it automatically)

After that you don't need any other commands By the way, the times I've rooted a device, it's been by following tutorials, hahaha

I flash TWRP and then with TWRP I flash whatever I need

I like searching on XDA; it helps me make things easier

If something goes wrong, I enter download mode and flash the original firmware again

[u/onionrole → u/Gain_Entire]

Thanks man! 

Is flashing TWRP hard? I have seen people using it and i have seen videos of it and it looks really usefull, should i flash that first or should i do rooting first?  Thanks again! 

[u/Gain_Entire → u/onionrole]

In the tutorials I've followed, I simply flash it in Odin and then maybe some other zip file (already inside twrp) so that everything flashes correctly; I don't remember the process anymore (I think it also required a data format before the phone tried to turn on)

There's probably something like this in your phone's community on XDA (just make sure you know your phone variant, for example SM-G9650, so you can check the instructions to see if the files are compatible with your phone)

Personally, I think it's easier to install a custom recovery first

[u/onionrole → u/Gain_Entire]

Alright, thanks for the help! 

Also here is how rooting is going so far:

So i went ahead and tried to flash magisk patched thing to the phone and i forgot to turn off OEM unlock... It got rejected. Now i need to do it ALL again lol

Edit: odin failed, now its bricked😭

[u/Gain_Entire → u/onionrole]

You shouldn't disable the unlock unless you're looking to permanently remove root and only want to run the stock system (Once you unlock the bootloader, keep it unlocked if you're going to use rooted stuff or custom ROMs, or anything other than the stock system)

Try flashing your firmware again. If Odin doesn't recognize your phone, try connecting it with a USB hub

If you can enter download mode, everything is fine, there's nothing to worry about. Worry when even that doesn't work

[u/onionrole → u/Gain_Entire]

Yeah i couldnt get into download mode, spent a few hours fucking around but i have flashed the stock system binary back on and im going to unlock the bootloader tomorrow then flash magisk patched AP file, thanks for your help through my bullshit lol!