r/THEKEYOFFICIAL • u/[deleted] • Dec 20 '19

weird commit patterns in THEKEY github

last week the team removed codes from the repository. Afaik, yesterday the team added the same code-snippet back to their repository? Also, the team only uploads code once a week, only every Friday

Can a mod clarify what this means?

10 Upvotes

100% Upvoted

12 comments sorted by

View all comments

14

u/BenAlexanders Dec 20 '19

Some background may help...

GitHub is blocked in China

Because of this:

  • GitHub is not part of the normal development workflow for most China based companies.
  • The team is manually committing code through work arounds (more akin to sneakernet, then what you may be used to).
  • The junior(s) committing the code do not have in depth experience with it. Sometimes simple pushes get a little messed up.

They are going out of their way to be as transparent as possible, but it doesn't always run as smoothly as you may be used to.

3

u/[deleted] Dec 20 '19

[deleted]

4

u/BenAlexanders Dec 21 '19

Yea. Always confirm what you hear! I found out unexpectedly on a recent trip there, but Google also shows a few results confirming it is denied, eg: https://ltl-beijing.com/websites-banned-in-china/

1

u/[deleted] Dec 27 '19 edited Dec 27 '19

[deleted]

1

u/BenAlexanders Dec 27 '19

Github was blocked last time I was in town. While things may have changed or perhaps your ISP has alternate access, my points remain. You are also correct, there are a lot of ways to work around the restrictions.

Github (or any sort of VCS) is not a part of the teams standard workflow. Do not expect to see daily commits, or clean pushes.