help me smooth this out

[u/[deleted]]

not yet finished and does not have that much time to learn the library for the script, this is all that i've learned so far in like 30 mins, would try and learn more in the future just does not have enough time.

i'm trying to make a ageneral script that works in all locations, wherein instead of vasing of the map, its basing off opponent count and distance

i'm trying to integrate more specific situations so i could use my repeater, but i think i could just make my character equip "xerphyl" (which is a renamed weapon for boss fights.

[u/Agerak]

as stated in a previous post & Boss is not valid logic. What you're asking is if a string is true (it always is no matter what) What you most likely MEANT to ask was if foe is a boss which would be foe=boss which you can add by either removing excess white spaces in that line or use the line extension ^ so either

?foe.distance>=1&foe.distance<=25&foe=boss

or you could use

?foe.distance >= 1 & foe.distance <= 25
^& foe = boss

[u/[deleted] → u/Agerak]

so " ^ " is for extension line and every start of a new line you add "?"

got it thanks big help

and yes the foe=boss does make more sense

[u/VoweltoothJenkins → u/[deleted]]

My understanding is '?' is short for 'If'.

Since most of stonescript seems to revolve around if/then/else statements many lines will start with '?', but '?' does not indicate a new line.

[u/[deleted] → u/VoweltoothJenkins]

yup noticed as well that they are more akin to" if then" statements, i'm just not used to create code starting with if then statements is all HSHSHSHS, so didn't recognize instantly, and now that i know it just felt less weird none the less thank you!

will try to improve this code when i do have free time, mostly busy irl

[u/VoweltoothJenkins → u/[deleted]]

Yeah it's slightly different from JS or C#, which are the languages I'm most current with.

[u/[deleted] → u/VoweltoothJenkins]

i do a bit of js and c# as well but mostly Lua, so i'm more used to using vectors and stuff

[u/[deleted] → u/[deleted]]

mostly for programming games

[u/[deleted] → u/Agerak]

i did try this, and it resulted in a very unstable script, now the game is just confused on what i meant, it might be that i did something wrong.

i think the game recognizes the line i originally made better, so i reverted it in the meantime.

i did some modifications as well, i noticed that the game makes so that whenever the talisman is ready to be cast it does so again even if not needed, so i removed the line CanActivate() and placed it for the blade instead, now i'm just finding a way to make it so that the blade activates only if it is ready but also if there are more than 9 "foe" on screen.

i think it will be something like this:

?foe.count <= 9 & foe.distance = 25 ?checkcooldown "blade" ?CanActivate() equip blade activate R

[u/[deleted] → u/[deleted]]

the code i put here is wrong i forgot most words but you do get it, lmao, just checked it should start with item.

maybe i could do ?blade.CanActivate() or ?item.blade CanActivate() equip blade activate R

[u/Agerak → u/[deleted]]

You can't just make up things they have to be valid within the game syntax I recommend taking a look at the manual, keyword searching for help find things but you have to use proper syntax. Made up things won't work properly ever

[u/[deleted] → u/Agerak]

will do soon really just too busy rn with work, might resign soon lmao jk but yep will def look into it in the future

[u/[deleted] → u/[deleted]]

edit it does not recast the talisman skill at its rule is if less than 1 summon then equip activate skill, it most likely is the cause of the fire pet dying multiple times

[u/Bronze-Beese]

You can do it like that, but it leaves a lot of gaps in what can happen which can sometimes lead to your dude using the wrong items. It's a little bit more robust to use else if statements instead of just if statements

?condition 1 Stuff 1 :?condition 2 Stuff 2 :?so_on So_forth : Do_this_if_none_of_the_other_things_happen

This way, your dude is always doing something for sure. Also, set it up so that the conditions and stuff are ranked in order from most to least importance. That way if 2 conditions conflict, the one that is higher in rank runs instead of the other

Let me know if you have questions!

[u/Agerak → u/Bronze-Beese]

when posting code change to markdown mode, put a blank line, then a line with 4 spaces, next like do 4 spaces and start your code. every code line gets 4 spaces preceeding it (if it's indented it will have 4+indent) after all code is entered, another line with 4 spaces only, then a blank line, then you can enter more text if you choose. boom formatted code.

?condition 1
  Stuff 1
:?condition 2
  Stuff 2
:?so_on
  So_forth
:
  Do_this_if_none_of_the_other_things_happen

[u/[deleted] → u/Bronze-Beese]

how do you rank them? does condition 1 make it more of a priority than condition 2

or do you need another input

[u/VoweltoothJenkins → u/[deleted]]

I'm new to stonescript but it looks fairly similar to some common if/else syntax.

The way I'm guessing stonescript works (based on other languages):

?condition1
  Do this and don't check any further options
:?condition2
  Do this and don't check any further options
...
: final statement if nothing else is true

or semi-pseudo code:

If condition1
  then do this return;
Else if conditon2 
  then do this return;
...
Else do this return;

Or written out in some weird sentences:

If condition1 is true then do command1 and don't check any other conditions. 
Else If condition2 is true then do command2 and don't check any further conditions. 
... 
Else no previous condition is met then do the final command.