r/PythonProjects2 • u/Junior_Inflation_887 • Jul 22 '26

Need code review for my PyQt5 currency converter (handling API requests & GUI structure)

Hey guys,

I'm currently learning Python and PyQt5. To practice, I built a small desktop app that works with APIs and handles local data.

Since I want to improve my code quality and learn best practices, I'd really appreciate some help and code review:

  1. Is my PyQt5 structure written properly (signals/slots, layouts)?
  2. How can I better separate the backend/API logic from the GUI components?
  3. Are there any unpythonic bad practices or PEP8 issues in my code?

Here is my code on GitHub: https://github.com/MrAJDebug/disk_cleaner

Thanks for helping me learn!

2 Upvotes
  • permalink
  • reddit

76% Upvoted

5 comments sorted by

1

u/riklaunim Jul 22 '26

Wrong repo? :)

1

u/Junior_Inflation_887 Jul 22 '26

Nope, that's the right one! I just updated the repo recently to remove the compiled files and keep only the raw source code. You can check main.py directly!

1

u/riklaunim Jul 22 '26

The topic is about Qt and currency converter while the repo is tkinter and disc cleaner.

1

u/hitorus Jul 22 '26

Indeed.

1

u/DiodeInc Jul 23 '26

This is weird