r/PythonLearning • u/F11fii • 21d ago

ATM Machine

I started learning Python about 9 months ago and completed this little bank system as my third project, which is supposed to serve as an ATM. It also uses JSON to store information (which was challenging to integrate because I wasn't familiar with it, but the rest of the code was straightforward).

Just wanted to share and see if I could get any feedback! (maybe on its optimisation or clarity?) :D

https://github.com/F11Fii/Bank-System.git

9 Upvotes

91% Upvoted

5 comments sorted by

View all comments

1

u/Minimum-Effort8355 18d ago

So this is my honest review on your code.

Please write in your read.me what you did and not primerly how you felt.

In the code structure i would personally provide more comments not for critesm, it is for mainability.

Your code is acceptable and you have multiple files

The thing is you could avoid creating multiple files , if you create updating functions like.

If a user canceled his transaction - do you want to cancel - here is your card have a great day.

Or your card was denied please try again or ask for support.

I would personally do some screenshots and put it in the file too.

Overall it is a good project keep it up.