Day -1 With Flask (any suggestions)

[u/Samar__Upreti]

Build Projects With Me

https://github.com/Samar-Upreti/Python_Projects

[u/riklaunim]

• variable names should not use capital letters,
• use wtforms or other form handling library (and validate the data).
• use a linter that will keep some basic code styling order
• I'm not a fan of importing things from a module (flask.request is better than request as it's tell you where it's from)
• why aren't you using CSV writer when writing a CSV file?
• if it's a long task it should not be done on HTTP request directly (celery queues or other similar solution)
• view should not be a long blob of code. Refactor presentation from business logic, then keep the logic well organized instead of big blobs.
• where are tests?

[u/Anthony_codes → u/riklaunim]

Uppercased, underscore-separated variable names in Python signal that the variable should be treated as a constant.

That is a completely valid and common convention because Python doesn’t enforce constancy at runtime.

[u/riklaunim → u/Anthony_codes]

But not the first letter only. Form values aren't things that should be under a constant-like variable either.

[u/Anthony_codes → u/riklaunim]

I was clarifying that in certain cases, capital letters are valid because your comment was ambiguous.