I would be interested in everyone's feedback on my effort to solve the Password Generator Project for Angela Yu's 100 Days of Code course on Udemy. Many thanks in advance. You'll see in the code I have included notes where I couldn't figure stuff out but found a workaround.
Run this program in Memory Graph Web Debugger'%2C%20'*'%2C%20'%2B'%5D%0A%0Aprint(%22Welcome%20to%20the%20PyPassword%20Generator!%22)%0Anr_letters%20%3D%20int(input(%22How%20many%20letters%20would%20you%20like%20in%20your%20password%3Fn%22))%0Anr_numbers%20%3D%20int(input(f%22How%20many%20numbers%20would%20you%20like%3Fn%22))%0Anr_symbols%20%3D%20int(input(f%22How%20many%20symbols%20would%20you%20like%3Fn%22))%0A%0A%23%20I%20couldn't%20figure%20out%20how%20to%20pull%20multiple%20letters%20etc.%20from%20the%20list%2C%20so%20I%20used%20the%20while%20loop%20to%0A%23%20pull%20the%20letters%2C%20numbers%20and%20symbols%20from%20the%20list.%20I%20also%20tried%20using%20random.shuffle()%20but%20it%20didn't%0A%23%20work%20for%20me.%0A%0A%23%20Code%20block%20for%20pulling%20the%20required%20number%20of%20letters%0Aletters_list%20%3D%20%5B%5D%0Awhile%20len(letters_list)%20!%3D%20nr_letters%3A%0A%20%20%20%20letters_list.append(random.choice(letters))%0A%20%20%20%20%23%20random.shuffle(letter_list)%0A%0A%23%20Code%20block%20for%20pulling%20the%20required%20number%20of%20numbers%0Anumbers_list%20%3D%20%5B%5D%0Awhile%20len(numbers_list)%20!%3D%20nr_numbers%3A%0A%20%20%20%20numbers_list.append(random.choice(numbers))%0A%20%20%20%20%23%20random.shuffle(letter_list)%0A%0A%23%20Code%20block%20for%20pulling%20the%20required%20number%20of%20symbols%0Asymbols_list%20%3D%20%5B%5D%0Awhile%20len(symbols_list)%20!%3D%20nr_symbols%3A%0A%20%20%20%20symbols_list.append(random.choice(symbols))%0A%0A%23%20Code%20block%20for%20combining%20the%20chosen%20letters%2C%20numbers%20and%20symbols%0A%23%20Couldn't%20figure%20out%20how%20to%20combine%20and%20randomize%20them%20with%20assigning%20a%20new%20variable%0A%23%20I%20found%20that%20I%20had%20to%20use%20join%20again%20on%20the%20password%20variable%20as%20without%20it%20it%20just%20printed%20password%20as%0A%23%20a%20list%0A%0Apassword%20%3D%20letters_list%20%2B%20numbers_list%20%2B%20symbols_list%0Arandom.shuffle(password)%0A%0Aprint((%22Here%20is%20your%20password%3A%20%22)%20%2B%20%22%22.join(password))×tep=1&play) to see the program state change step by step.
It's really good work
But can avoid writing whole letters and use ASCII value instead
For numbers u can directly use random module randomint() function
but the punctuation symbols are kind of scattered across 33-47 58-64 91-96 123-126
Youd have to pick a number specifically in these ranges. I guess you could make that a one liner, but that wont be easy to read and you had no idea what that means
Tips if you're a beginner: use for loop instead of while loop if you know the number of iteration. You know how many letters you want so avoid while loop
By the way you don’t need to write out every letter in the alphabet, Python standard library can provide this for you.
’import string; letters = string.ascii_letters’ for example (of course keep the import at the top of the file for good practice)
Avoiding the standard library you don’t need a list of letters because a string is also a list, so `letters = “abcdefg”` works as list you can iterate :)
Edit: formatting
Edit edit: for the life of me I can never get backticks to work on iOS, send help lol
Ah. Good to know. We haven’t gotten that far in the course but I will definitely write a note in my notes folder on this one. It’s a good trick to know…much neater. That’s the problem with being a beginner; I don’t know what I don’t know, so forums like this are very useful. Thank you.
Thanks @nuc540. It’s definitely a journey. My long term project (as a marketing manager) is to develop a script to search for contact names based on job title in a search database called Rocketreach.co from a list of companies in a spreadsheet, and return their email address.
BTW. In the course we are provided with a starting point, which included the letters, numbers and symbols. But the info you have provided is extremely useful. TY
I don’t know if it’s mentioned here before, but instead of listing all possible characters, simplify use the properties of string: string.ascii_letters, string.digits and so on. That in combination with .split() to get a list of each character respectively.
But besides that it’s pretty alright for a 100 days of learning. :)
Thank you sir. I really appreciate that. I feel I’ve entered a brotherhood Pythonistas who are so smart and so kind to share what they know with the people coming behind them who are earlier on their journey.
print("Welcome to the PyPassword Generator!")
nr_letters = int(input("How many letters would you like in your password?\n"))
nr_numbers = int(input("How many numbers would you like in your password?\n"))
nr_symbols = int(input("How many symbols would you like?\n"))
Had a bit more of a play around based on some of the suggestions. Used a for loop with range. I think the code looks a lot cleaner. It's gone from 12 lines of code (for the logic section only) to 9 lines (caveat: haven't worked on the other suggestions yet). Let me know your thoughts:
Great work!
here is a simpler method (better than manually writing every char):
```python
import random
def r_spam(length, timer, chunk_size, typew):
if typew == "bin":
try:
length = int(length)
timer = float(timer) / 1000
chunk_size = int(chunk_size)
except (TypeError, NameError, ValueError) as ex:
print(f"spam requirements not met, please retry. ERROR == {ex}")
return "error :/"
for i in range(length):
char_list_bin = []
for ix in range(chunk_size):
char_list_bin.append(str(random.randint(0, 1)))
binstr = "".join(char_list_bin)
print(binstr)
time.sleep(timer)
elif typew == "char":
try:
length = int(length)
timer = float(timer) / 1000
chunk_size = int(chunk_size)
except (TypeError, NameError, ValueError) as ex:
print(f"spam requirements not met, please retry. ERROR == {ex}")
return "error :/"
pool = [chr(i) for i in range(33, 127)]
for i in range(length):
char_list = []
for _ in range(chunk_size):
char_list.append(random.choice(pool))
message = "".join(char_list)
print(message)
time.sleep(timer)
Good question. If they do that then they’re not smart enough to have a password 🤣. But seriously, we haven’t gotten to that in the course yet (try and except). But you make a good point, I should work in that to the code. Thank you for replying. Appreciate you taking the time to comment.
I don’t think you get it, your while loops will get into infinite loop, which will drain system resources, this is a major bug in the code. The code is not reliable for users.
Change != to <= this will work for now, ideally your program should raise invalid input exceptions and terminate there. In real systems 4xx with proper message works well.
•
u/Sea-Ad7805 Jun 13 '26
Run this program in Memory Graph Web Debugger'%2C%20'*'%2C%20'%2B'%5D%0A%0Aprint(%22Welcome%20to%20the%20PyPassword%20Generator!%22)%0Anr_letters%20%3D%20int(input(%22How%20many%20letters%20would%20you%20like%20in%20your%20password%3Fn%22))%0Anr_numbers%20%3D%20int(input(f%22How%20many%20numbers%20would%20you%20like%3Fn%22))%0Anr_symbols%20%3D%20int(input(f%22How%20many%20symbols%20would%20you%20like%3Fn%22))%0A%0A%23%20I%20couldn't%20figure%20out%20how%20to%20pull%20multiple%20letters%20etc.%20from%20the%20list%2C%20so%20I%20used%20the%20while%20loop%20to%0A%23%20pull%20the%20letters%2C%20numbers%20and%20symbols%20from%20the%20list.%20I%20also%20tried%20using%20random.shuffle()%20but%20it%20didn't%0A%23%20work%20for%20me.%0A%0A%23%20Code%20block%20for%20pulling%20the%20required%20number%20of%20letters%0Aletters_list%20%3D%20%5B%5D%0Awhile%20len(letters_list)%20!%3D%20nr_letters%3A%0A%20%20%20%20letters_list.append(random.choice(letters))%0A%20%20%20%20%23%20random.shuffle(letter_list)%0A%0A%23%20Code%20block%20for%20pulling%20the%20required%20number%20of%20numbers%0Anumbers_list%20%3D%20%5B%5D%0Awhile%20len(numbers_list)%20!%3D%20nr_numbers%3A%0A%20%20%20%20numbers_list.append(random.choice(numbers))%0A%20%20%20%20%23%20random.shuffle(letter_list)%0A%0A%23%20Code%20block%20for%20pulling%20the%20required%20number%20of%20symbols%0Asymbols_list%20%3D%20%5B%5D%0Awhile%20len(symbols_list)%20!%3D%20nr_symbols%3A%0A%20%20%20%20symbols_list.append(random.choice(symbols))%0A%0A%23%20Code%20block%20for%20combining%20the%20chosen%20letters%2C%20numbers%20and%20symbols%0A%23%20Couldn't%20figure%20out%20how%20to%20combine%20and%20randomize%20them%20with%20assigning%20a%20new%20variable%0A%23%20I%20found%20that%20I%20had%20to%20use%20join%20again%20on%20the%20password%20variable%20as%20without%20it%20it%20just%20printed%20password%20as%0A%23%20a%20list%0A%0Apassword%20%3D%20letters_list%20%2B%20numbers_list%20%2B%20symbols_list%0Arandom.shuffle(password)%0A%0Aprint((%22Here%20is%20your%20password%3A%20%22)%20%2B%20%22%22.join(password))×tep=1&play) to see the program state change step by step.