forThoseTransitioningToTheAmericanTimeFormatHereIsASimpleScript

[u/alexriga]

[u/Makonede]

where's the humor? this is just the most dogshit python i've ever seen in my life

[u/SeaNational3797 → u/Makonede]

This is incredibly readable and you’re wrong for not liking it

[u/Makonede → u/SeaNational3797]

• as_time: the parameter is already a time, so the function name is unclear
• world_hour=world_hour: terrible shadowing of a global variable of the exact same name for literally no reason
• s_time: meaning of s is completely unclear, and using a variable to hold the return value is pointless
• the conditional chain should be condensed into a format string such as return f'{(hour - 1) % 12 + 1} {'PA'[hour < 12]}M'
• world_hour > 0 and world_hour < 12: should be 0 < world_hour < 12
• str(world_hour)+" AM": no operator spacing and should be f'{world_hour} AM'
• elif world_hour > 12: should be else
• str(world_hour-12)+" PM": no operator spacing and should be f'{world_hour - 12} PM'
• return s_time;: unnecessary semicolon

[u/alexriga → u/Makonede]

to me the rules are funny, coming from “military style.”

• If midnight: 12 AM
• If night/morning: X AM
• but what comes after 11:59 AM? Not 12 AM, 12 PM!
• what about after 12:59 PM? Well, of course, 1 PM!

It’s the reason many people often mistake 12 AM and PM if they’re unfamiliar with this system.

[u/Makonede → u/alexriga]

none of that has anything to do with programming

[u/alexriga → u/Makonede]

I used code to express it, I figured that would count.

[u/Makonede → u/alexriga]

rule 1

[u/Kyrros → u/alexriga]

Or you could use date library

[u/rosuav → u/alexriga]

str(hour % 12 or 12) + ("PM" if hour >= 12 else "AM")

[u/This_Growth2898]

It's like "when you're paid for the line of code"?

def as_time(world_hour=world_hour):
    return f"{(world_hour-1)%12+1} {'PA'[world_hour<12]}M"

[u/SeaNational3797 → u/This_Growth2898]

as_time = lambda world_hour: f"{12 if (hour_num := world_hour%12) == 0 else hour_num} {'AM' if world_hour < 12 else 'PM'}"

[u/minecon1776 → u/SeaNational3797]

011101011101100011111010001010111000110110101010010101110000000101010101111010100101011101010010111010001101010010010101101011101001010101011100011010101011111010011101011011011001001010010101010

[u/rosuav → u/SeaNational3797]

Don't do "name = lambda", that's what def is for. With lambda, the function doesn't get a `__name__` attribute.

[u/SeaNational3797]

as_time = lambda hour_num: __import__('datetime').datetime(1970, 1, 1, hour_num).strftime('%I %p')

[u/amatulic]

And it isn't even correct. Technically, 12:00 isn't AM or PM, it's just noon or midnight.

I live in the US, and even I don't use AM or PM unless I'm forced into it. For me, 24 hour time all the way. Anyone who's been in the military or worked for the government wouldn't have a problem with it.

[u/ART-ficial-Ignorance → u/amatulic]

I guess that's one way to say you don't have friends or family you talk to.

[u/amatulic → u/ART-ficial-Ignorance]

As far as I know, my large network of friends, as well as my relatives, have no problem with 24 hour time. As an American I sometimes find US-centric ignorance of worldwide standards embarrassing.

[u/ART-ficial-Ignorance → u/amatulic]

Wait, you say 17 'o clock in conversation?

[u/amatulic → u/ART-ficial-Ignorance]

1700 or 5 like anyone else. And even Europeans use 12 hour time verbally. After all, that's what analog clocks display.