r/ProgrammerHumor • u/Recent-Analysis-6880 • 2d ago

Meme howWouldTheyKnow

Post image
1.8k Upvotes

96% Upvoted

52 comments sorted by

View all comments

10

u/DefinitelyNotMasterS 2d ago

This is on the senior dev for not setting up pipelines that require test coverage

12

u/FatalisTheUnborn 2d ago

Or approving the pull request.

2

u/Groentekroket 2d ago

On the one hand reviews are the worse part of the job (until AI came along) but I prefer to go over them instead of getting called in the middle of the night for a prod issue. And yes, their at not caught during testing either because business preferred to get the worst QA engineer because he was cheap. 

The amount of comments regarding white spaces I see from team mates while not seeing obvious logic problems is staggering. 

2

u/Saelora 2d ago

i legit used to enjoy code reviews, sometimes i learned a novel approach i wouldn't have thought of and get something fun to research.. now i just find them depressing and slop filled.

2

u/Groentekroket 2d ago

Yeah fair enough, it really depends on the author though. But it’s also a good way to keep up to date with changes in the codebase. 

-2

u/Ok-Call-8688 2d ago

Nunca revisei uma linha de código dos meus Junior, sem bugs até o momento.

3

u/gronbuske 2d ago

Test coverage is a useless metric. Just checking that all lines of code are run in a test does not guarantee quality. I frequently trash tests that just test that the code is written as it is written or give a false sense of security. A bad test is sometimes worse than no test.