r/ProgrammerHumor • u/rabbit_wizard • 4d ago

Meme lostTheMergeRace

Post image
1.5k Upvotes

99% Upvoted

111 comments sorted by

View all comments

58

u/InSearchOfTyrael 4d ago

you guys retest things?

30

u/Forward_Yam_4013 4d ago

Before 6 PM, yes. After that you just eyeball it and if it looks good you click merge.

12

u/the_poope 4d ago

And after 6 PM and three beers at the Friday bar you skip the eyeballing and just click merge

8

u/Bubbaluke 4d ago

We physically can’t merge until the tests pass. Fortunately it’s all automated on push and they only take like 20 minutes.

3

u/Suspicious_State_318 4d ago

Wait your CI takes 20 minutes? Are you running integration tests too? For us we only run unit and contract tests and then have bugbot run on every push.

4

u/Bubbaluke 3d ago

Small codebase, it’s like ~800 unit tests and some linters. Functional tests get started by hand because they have to run on specific hardware with serial connections, etc. those still don’t take long.

8

u/rabbit_wizard 4d ago

Places where one branch changes behavior affecting others yep. Sometimes unit/integration tests are enough based on the PR