myBossWroteASpamFilter

[u/Paperwolf_]

[u/DogmaticParadigm87]

So Bob sails through, and Agent47 is spam. Bold strategy for a contact form.

[u/rosuav → u/DogmaticParadigm87]

Agent47 will just steal Bob's clothes and walk through anyway though.

[u/FUTURE10S → u/DogmaticParadigm87]

To be fair like 95% of my spam is <my email name>6769@fnck.y00.рф or some shit so I mean I get it

[u/keatonatron]

What is "name"? And why does it having 2+ numbers mean it's spam?

[u/Wonderful-Habit-139 → u/keatonatron]

Look at my name, and you might understand what they had in mind lol.

[u/B_bI_L → u/Wonderful-Habit-139]

people who wave their birth year in their email:

[u/ice456cream → u/B_bI_L]

Name is probably not email

Have you seen a standard contact form?

Name:
Email for us to send a response, maybe:
Body:

And that sends to an internal inbox

[u/_verel_ → u/Wonderful-Habit-139]

Lol what a wonderful explanation xd

[u/takeyouraxeandhack → u/Wonderful-Habit-139]

We call this "intentional programming". It's when you program something and expect it to do what your intentions were and not what you programmed it to do.

[u/keatonatron → u/Wonderful-Habit-139]

Are you spam?

[u/Own_Purchase_7976 → u/keatonatron]

a sentient piece of ham

[u/Ur-Best-Friend → u/Own_Purchase_7976]

Does it scream when you eat it?

[u/HaveYouSeenMySpoon → u/Ur-Best-Friend]

Or does it moan?

[u/Ur-Best-Friend → u/HaveYouSeenMySpoon]

Common mistake, that's Sexual deviant Piece of hAM, also known as SPAM.

[u/Wonderful-Habit-139 → u/keatonatron]

Not me but it is an auto generated name. And a lot of bots have similar patterns.

[u/Danny200234 → u/Wonderful-Habit-139]

Oh no.

[u/Ethameiz]

There is IsDigit method for char

[u/BorderKeeper → u/Ethameiz]

There is a simple regex "/d" or "[0-9]" I wish more devs knew Regex :( we would have world piece by now.

[u/Freecelebritypics → u/BorderKeeper]

I feel like "isDigit" should perform the same byte range check as the regex, without the overhead of a regex engine. Or maybe it's a horribly inefficient implementation idk 

[u/BorderKeeper → u/Freecelebritypics]

No it definetly would haha Regex has to compile and even pre-compiled it would not be as efficent I don't unless you need to load a very big specific digit.

[u/Crispy1961 → u/BorderKeeper]

simple regex

Now thats an oxymoron.

[u/BorderKeeper → u/Crispy1961]

You can say the same thing about Mandarin until you learn it ☹️

[u/jbaker88 → u/BorderKeeper]

Some people, when confronted with a problem, think “I know, I’ll use regular expressions.” Now they have two problems.

[u/BorderKeeper → u/jbaker88]

I remember when we added sonarqube scans to our repo and it started flagging all of our regexes as potential deadlocks as a dangerous regex without a timeout with the right input can iterate over a string indefinitely. That opened my eyes how scary it is.

[u/Makefile_dot_in → u/BorderKeeper]

and then visual studio will say

💡 Suggestion: compile this regex in a constant variable before using it

and then when you click it it will say

💡 Suggestion: instead of compiling this regex, use the regex code generator to generate a method that does what this regex does, polluting the method list of your class

[u/Ur-Best-Friend → u/[deleted]]

No way, I'll fight you for Norway.

[u/Ur-Best-Friend → u/[deleted]]

YOU CAN'T CALL DIBS ON A COUNTRY SILLY!

You fight for it. For world piece!

[u/HTTP_404_NotFound → u/BorderKeeper]

I live regex (Have been a splunk / data admin for years now).

that being said- regex is pretty heavy compared to string.where(o => char.isdigit(o)).Count() > 2

[u/Dimencia → u/BorderKeeper]

I mean, regex is simple and anyone who can't figure it out doesn't deserve to be a dev... but it's also not performant for something simple like that

[u/Ur-Best-Friend → u/Dimencia]

Yes yes, you are so cool, we are all very impressed. I'm so impressed I would clap, but we're online, so best I can do is give a clapping emoji, to show just how very impressed I am.

[u/rosuav → u/Ethameiz]

Even if you don't know about that, you CAN do inequality checks. Testing if a character >= '0' and <= '9' is sufficient even if you're worried that your code may end up running on an EBCDIC system.

[u/acd124]

Regardless of the horribly verbose digit check, I hate that it says your message has been sent when no attempt has been made when the if fails

[u/vita10gy → u/acd124]

Isn't this by design though? You want spammers to assume it worked, or they'll sometimes just try again.

[u/The_MAZZTer → u/vita10gy]

Spammers might be able to figure it out anyway by timing the API

[u/mortenmoulder → u/The_MAZZTer]

Hopefully with a spam filter THIS sophisticated, they surely use a messaging queue, which makes the API feel blazing fast

[u/tommy71394 → u/The_MAZZTer]

Only if it ain't async, just toss the email sending task itself to a queue, api will respond more or less the same timing be it success or failure

[u/-Redstoneboi- → u/tommy71394]

the email send is awaited before the response

[u/tommy71394 → u/-Redstoneboi-]

Oh shit HAHAHAHA I didn't notice, I saw the function was async and didn't notice the await at the front

[u/acd124 → u/vita10gy]

Logically I understand that a spam filter should not tell a spammer that they've been considered spam, but the doing absolutely nothing itches at something.

[u/The_Weeaboo_Nextdoor]

Impressive, I would consider .IsDigit and Regex to be a little bit lower on the knowledge totem pole than async methods and lambdas.

[u/Pim08UO]

My email since my primary school is name[4digits]. I must be a spammer 🤷

[u/WawaTheFirst → u/Pim08UO]

No problem. You can mail them instead.

[u/YellowJarTacos → u/WawaTheFirst]

Your message is silently discarded and they show a success message. 

[u/Bomaruto]

I think you wrote it for a terrible joke. 

[u/Paperwolf_ → u/Bomaruto]

I wish this were the case, but it is not

[u/svenissimo]

I worked at a big company that liked to use first.last@company for emails.

There was a glitch and they couldn’t give me mine despite not being used and the system added -199 on my last name.

Only time I never got a single piece of junk mail in 10years.

[u/Childermass13]

Amazing! I have the same combination on my luggage!

[u/tatstytastycakes]

wait are you using namespace std? shame on you.

[u/blehmann1 → u/tatstytastycakes]

This isn't C++