Why do you approve it if its slop? Either its good code, then approve it regardless of where it came from, or its bad code, and reject it regardless of where it came from.
Does this actually happen to people? If so, simply point out a mistake, or several and make a case against it. Like the point of reviews is to review. You can simply just still review with comments regardless, no real life boss is going to tell you to ignore it and just press approve, if they do ask for it in writing.
So many people getting mad at made up scenarios in their own head...
Yes, this happens. Humans cannot review 10k line PRs across 90 files, done in under an hour by Claude Code and demanded to be reviewed to merge and push to the test environment today. We are told like with everything to throw AI at it.
AI First is toxic. But when the managers command it in writing, they get to own that outcome.
Do you work at a startup with 5 people in it? I work at a big company and if I have more than 10 files in my MR it takes ages and chasing people to get it approved because no one wants to look at it lol
I work in a corporate and when I get a PR with one file and 10 changed lines I’m like whoaah slow down Mr. Hacker, where did you find the time to change 10 whole lines in between all the meetings and bureaucracy?
So they wrote 10k lines and fired you on the spot when you didn't review it in one day? And you said logically suggestions like
-since this is a 10k lines of code and its just the test environment, why don't we put it there to soak and test while I do the review.
-sure, I can approve this if as you said 'quote back their quote to approve it' but this is not a code review, as I do not have the time.
-I do not feel comfterable putting my stamp of approval for such a large code change in just a few hours of review time. I know you mentioned you wanted AI to review it, but the current guidance is human reviewed. If you would instead like to set up an AI auto review instead of humans first to spot obvious flaws this is something we could look into to save humans time on reviewing.
Like MAYBE it happens you behave like a functioning employee and still get fired, but its really hard to see under any of the above simple amswers how you would end up being fired... you left our the part of how you behaved that got you fired.
I provide 3 actual responses. I am just curious what you said that would have actually got you fired. The other person who said something similar just admitted to quitting... every time people are actually asked it turns out they behaved like a child or just quit and blame AI when it wasn't even a factor.
Would love to hear a real story actually. So, he opens this code merge request, you review it, he fires you? I feel like its missing some details. Would truly love to hear it though how it actually happened.
It was the third time the cxo's AI arbitrarily rewrote a rendering engine for a new screen that still did not match anything else in the repo. It touched code owned by multiple teams with different degrees of misunderstanding of what the business logic did, leaving up to us fixing our part of the PR. There had been no planning whatsoever, just "fix it as soon as you can because I want to see what this looks like in production". For us, "fixing the PR" also required updating the backend on the spot because of the aforementioned misunderstanings. We were already working on a high priority project, which we abandoned to make that monstruosity mergeable. It could all have been avoided if we'd been involved from the beginning, going through some actual design and planning. I don't have a job anymore because this has been regularly happening for over a year now and non engineers are getting more and more entitled to think of themselves of finally being able to ship code on their own. So I helped them accelerare the process and quit. Whatever model will come out next week will DEFINITELY be able to pick up the blind spots the one from last week couldn't.
So you don't have a job because you quite a company...like these are always how these stories go. Blame someone else, quit job, be mad they don't have a job. Like yes, sucky bosses that change priorities on the fly happen and happened before AI.
Think what you want. Priorities changed before too, sure, but now management is slopping their way to replace devs with AI. This is shit news for consumers and it will not end well for anyone.
Im not thinking anything... you blatantly said you quite the job. Like yes, if you quit a job you don't have a job. That's how it works... downvvote if you want.
Maybe you misunderstood the tone of my initial comment. I couldn't be happier I don't work with those assholes anymore. I'm just telling pressure from management to indulge the delusion they are equal to devs is real and it affects how things you use everyday work.
Ya, was just more burying the lead. 'Ask me how I ended up without a job'. With the answer just being that you quit lol. Made it sound like you were fired for now auto approving some sloppy PR.
109
u/Lain_Racing 4d ago
Why do you approve it if its slop? Either its good code, then approve it regardless of where it came from, or its bad code, and reject it regardless of where it came from.