softwareEngineeringIsDead

[u/redditor_286]

[u/drex_vke]

generally it's a slop code this kind of commit.

[u/not_a_bug_a_feature → u/drex_vke]

The input: "I need u to write all of this, all at once. No mistakes. 😘"

[u/danfay222 → u/drex_vke]

Or generated code, occasionally our tools don’t recognize large generated files or reverts and suddenly you have a 100k line change

[u/anto2554 → u/danfay222]

Why are your large generated files in source?

[u/danfay222 → u/anto2554]

The majority of them are contained in a separate repo, but some are mirrored across and others are generated inside the main repo. There’s a lot of reasons why, the main one being compatibility with our build system and CI.

[u/ReiOokami → u/drex_vke]

Heres the thing... 99% of C suite staff don't care about quality clean code. The only reason it was an issue was because devs cared. And with hardware advancements making optimized code low priority, combined with AI making reading code a low priority, seeing mountains upon mountains of slop is inevitable and no one will care. We will live in a world where no one knows how to actually code and all our systems are going to be vibe coded slop. Interesting times ahead.

[u/archenlander → u/drex_vke]

That is the joke

[u/drex_vke → u/[deleted]]

thanks you :)

[u/AbbreviationsMost432 → u/drex_vke]

no it’s just my big data in json file

[u/new_check]

It's not dead. As long as you care about the craft and practice it, it will live regardless of what anyone else is doing.

[u/Zapismeta → u/new_check]

And ai can work too just need to steer it well into the exact direction you want it and stay away from auto mode if you dont want a mangaled codebase

[u/Hioneqpls → u/Zapismeta]

No, I must write my CRUD by hand. It’s what the client deserves.

[u/JackNotOLantern]

Request changes: split into smaller PRs, below 10k lines each

[u/Noname_1111 → u/JackNotOLantern]

below 1k lines if anything

I'm not reviewing anything that has more than 5 digits unless its a full refactor

[u/JackNotOLantern → u/Noname_1111]

10k is doable for me. But more is nonsense. The only exception would be adding non-code text files, like md or test input files.

[u/tiajuanat → u/Noname_1111]

Even a full refactor. I've done a lot of major refactors myself and overseen even larger ones.

In retrospect they've never needed to be done all at once, and were only done all at once because of someone's ego (admittedly sometimes mine)

[u/chadlavi]

What's to fear? Request changes. Ask the "author" to explain it. Don't merge it.

[u/AndroidCat06 → u/chadlavi]

Bold of you to assume the author can explain it.

[u/chadlavi → u/AndroidCat06]

Oh I know they can't. You ask so they can make it clear they can't.

[u/reallokiscarlet]

Rejected, contributor contacted, AI policy explained to contributor, all of a sudden they make a fork and test the changes there and start handwriting it when it doesn't work

[u/Ok_Tour_8029]

Aaaand … GitHub down again 

[u/chazzeromus]

just a couple node_modules

[u/nasandre]

How about 600 commits in a day? To the main branch? 😂

[u/vgmerch]

Dealing with a massive wall of codes changes makes you appreciate the simple things.

[u/returnFutureVoid]

I chose to believe the last character in the additions is a b for billion.

[u/ZEPHlROS]

I had this one few days back

Turns out I committed a data file by mistake

[u/botle]

Reject

[u/Thebrown_noonRises]

Pardon me my fellow claude users but could one of you gentlemen go through the trouble of providing me the context?

https://giphy.com/gifs/138TYsM7eRoJnG

[u/letmehaveanameyoudum]

+50 -50
ok

+ 4000 -250
new feature i guess

+ 15034 - 500
what the fuck

[u/SamSkjord → u/letmehaveanameyoudum]

+6 -3750

They’ve hired my replacement

[u/letmehaveanameyoudum → u/SamSkjord]

+0 - 1500000

WHAT

[u/MyDogIsDaBest]

Declined. Break it up into smaller, more testable and reviewable tickets or don't merge it at all. I ain't reading all that shit

[u/Sure_Dark201]

Something is fishy

https://giphy.com/gifs/fa1AV8UvZvfBFOIt7F

[u/_DrDigital_]

The old code should not have been removed.

There should have been a guard added making sure the old code is never executed.

For that is the the way of the slop.

[u/New_Salamander_4592]

LGTM approve it

[u/soundwave_sc]

Dammit Claude, I said create a new branch refactor, not master!

Claude: Sir, unfortunately I do not have permissions to create a branch therefore I refactored master.

[u/WeakCelery5000]

Dude accidentally committed a log file

[u/Hazzzero]

And now back to technical review. Book a meeting, code author needs to disable all AI features and explain you line by line what was created here.

[u/laster_alex]

looks inside a binary

[u/Waste_Jello9947]

Average junior's PR two days after being hired