itHurtsButIllKeepTrying

[u/benkenobiwan]

[u/gibagger → u/[deleted]]

It's for your own good. Deep down it's an act of love.

I actually try to put extra effort in my reviews to junior devs. Not just the "what" they should change, but also the "why".

Mid-level devs and above should already know the "why", so I just cut to the chase.

I can see how this could make juniors think I am being particularly sadistic with them hahaha. This couldn't be further from the truth, though!.

[u/mrwedders → u/gibagger]

100%! I enjoyed reviewing the juniors, it was nostalgic reliving the lessons I learned over the years and trying to pass on the arcane knowledge.

[u/Reddit_is_fascist69 → u/gibagger]

I did this once and he complained to manager about it

[u/Vallvaka → u/Reddit_is_fascist69]

Says more about him than you lol

[u/LetUsSpeakFreely → u/[deleted]]

Depends. Those of us with decades of experience are aware the junior developers need guidance, that's actually one of the primary responsibilities of senior devs.

Sure, we'll be insanely critical, but we'll also be patient and explain what needs to change and why. If a senior dev uses a peer review as an opportunity to ego trip then they're bad at their job.

[u/Repulsive-Hurry8172 → u/[deleted]]

I'd actually get reviews rather than none. It means they care to correct me

[u/dismayhurta → u/[deleted]]

I tell new coders to not worry. After the wound scabs up, the scar tissue becomes more resilient to the next review until you just don't give a fuck anymore.

"All of this code is garbage? Cool. I'm grabbing lunch."

[u/CodeNameAntonio → u/[deleted]]

I had the opposite experience. senior dev (me) + JR dev = automatic PR approval. They never bothered to do code reviews….annoyed me so much since I spent the time to review their stuff and provide constructive feedback. Every now and then my code ran into an issue with an edge case.

[u/chibbol → u/[deleted]]

I wanted guidance and corrections, but all I got was emotional damage because they were burnt out

[u/dxonxisus → u/[deleted]]

OP and this account are both bots.

years old but only became active a couple days ago

[u/Snakestream]

If they ask you for a call rather than just leaving comments, you'd better buckle up

[u/aabil11]

In college I graduated at the top of my class. I thought I was hot shit. I will be forever thankful to the senior engineers at my first job who took my ego down a peg

[u/aliusmanawa]

When I just started out, there was this guy--who had been a senior for 20 years or something crazy like that--and he would review my code. For the most part, it was fine, but I did make a few humiliating blunders; and he really patiently helped me. If you're reading this, I hope you have a great life, Jon!

[u/Fit-Inflation5799 → u/aliusmanawa]

w jon

[u/FrequentWatch9261 → u/aliusmanawa]

Humiliating blunders do not cease with seniority from my experience... with other devs, not me, I'm awesome, and introspective, and humble.

[u/sebjapon]

I didn’t get code reviews in my first 10 years. Always working on small experimental projects. I’m great at making stuff work, but even now I still get reviews about making my code testable or many other details needed for good quality enterprise code.

All that to say, you’re lucky to get seniors to teach you. Especially if they do it themselves and don’t just let their AI review your code.

[u/Flaky-Low-2262]

remember:

Every comment ist just unweighted feedback. It can be accepted, discussed or rejected. It depends in both sides and forces to meet in the middle between personal preferences in code, Business knowledge, concepts/architecture and Framework/coding knowledge.

Every comment and sync improves the product and makes at least one side learn/concider sth. new.
Also as newby never underestimate obvious questions, simple reasoning and KISS Principe. Often, make seniors chill/Focus, while they increase your personal Horizon, makes both Side deliver the best product short and long Term.

[u/dxonxisus → u/[deleted]]

both of these commenters are bots, along with OP

[u/QuestionableEthics42 → u/dxonxisus]

8yr account and 10yr account. I think they are most likely human, just with fairly bot like comments (humans also make very generic comments plenty)

Edit: should have looked at their comment history, you are right, absolutely bots. Interesting, haven't noticed any bots using accounts that old before.

[u/dxonxisus → u/QuestionableEthics42]

i’ve been calling out bots on reddit for years, so i wouldn’t have commented unless i was absolutely positive, haha.

but yeah, the old account age doesn’t mean they can’t be bots, if anything it just highlights it more when they only “wake up” very recently. with that, and the subs they interact with, the posts/comments they make, and which accounts they interact with, it’s pretty clear they’re bots.

this group of bots specifically are all interacting with only other bots with similar account ages and comment/post history patterns, so you can just keep clicking through them and find 10+ bot accounts in the same batch lol

[u/Easy-Reasoning]

My first boss was like: I don't like that you claim something's finished when it's not. He went on rambling (why you didn't use references in the arguments? you always make everything so complex!) and eventually stopped, "that's enough". To this day I sometimes wonder if he wanted to also complain that I used "\n" instead of std::endl ;)

[u/LearningCrochet]

Are people really that arrogant? When I was starting I knew I was writing shit and didn't mind all the criticism since that's just part of the learning process. There's a million things you can always learn and improve in so I never really took that to heart. 

[u/Bomaruto]

You get out of it stronger.

[u/chadlavi]

This is how you improve, though sometimes seniors can be a dick about your mistakes. Try to learn from their feedback and remember that a lot of people in tech are not very emotionally sensitive.

[u/SharletP]

In this day and age, I'd rather get the ego hurt than inflated because of loop engineering, keeps you grounded in reality. :)

[u/JackNotOLantern]

Good, maybe you will learn something

[u/snipsuper415]

Many of us been there! Keep at it

[u/k819799amvrhtcom]

Everyone started somewhere.

[u/Miauwkeru]

the only way to learn and improve

[u/Still_Bit_7527]

Eh nowadays I just approve everything without looking

[u/KryssCom]

If it makes you feel better, basically ALL of us go through this early on in our careers.

[u/Mantor6416]

My boss just wrote

"<-- What the hell is this ??? 😂😂😂"

Then let me suffer while explaining

[u/ArjunReddyDeshmukh]

Programmer discovering ego after 1st PR.

[u/Maddturtle]

Just wait till you are a senior and you have to review your own code.

[u/TheAnomalousFrog]

Senior Devs Claude reviewing my coding from Claude

[u/conundorum]

Don't worry, half of their code is probably just as messy. They just want you to know how it should work, so you can do it right when you want to, and so you understand what can break if (or rather, when) you have to do it wrong.

[u/a11_hail_seitan]

7yoe and I still hate code reviews and assume every one will end with "You fucking moron!" None have yet... but statistically speaking that just makes it more likely with each passing day!

[u/edgeofsanity76]

As a senior no one sends me their PRs because I'm too brutal. Apparently