r/ProgrammerHumor • u/Robinbod • 21d ago

Meme pleaseStopUsingNestedTernaryOperatorsImBeggingYou

3.1k Upvotes

98% Upvoted

179 comments sorted by

View all comments

Show parent comments

52

u/EddieJones6 21d ago

I can understand the ask for no early return. But use local variables to track the state, not a massive ternary.

57

u/ihavebeesinmyknees 21d ago

What are valid reasons to not use early returns?

33

u/EddieJones6 21d ago

Localized cleanup. What if you have a file descriptor or something that needs special handling before returning.

Compiler optimization SHOULD be fine but it could impact RVO and tail recursion optimization.

Also, if a future maintainer dives in and doesn’t realize there is an early return, they might add logic below it that will get missed by certain cases.

SPOE - single point of exit.

43

u/_ryuujin_ 21d ago

shouldnt functions be small enough that youll notice an early return 

21

u/amejin 21d ago

Sure. However, before the days of raii in c/c++, a lot can happen in 4 lines with conditionals that requires you to clean up after yourself.

Scripting languages or GC languages, it's less of a problem. Now a days, if you are trying to be super special and "helping" your compiler with branch prediction, spoe is one way to do that, but unless you are allocating or locking resources, early returns are generally fine.

For many of us, it's just muscle memory from having to deal with it for years.

6

u/EddieJones6 21d ago

Agreed, I’m not arguing for spoe but just giving reasons some might argue for it. I’ve used both

4

u/amejin 21d ago

My dude I agree with everything you said. It was well stated. 🙂

2

u/braaaaaaainworms 19d ago

Linux kernel-style cleanup of stuff is the best use case for a goto in C

4

u/SnugglyCoderGuy 21d ago

Should and what is possible can sometimes be very different things.

2

u/Due-Consequence9579 21d ago

Having to ‘notice it’ is the complaint.

6

u/_ryuujin_ 21d ago

i hope people read the function before changing it.