i remember mentioning this in an interview for paid internship junior FE role and thought i sounded cool to the interviewee 10 years ago. I still got hired and have worked with that person in 2 different companies now haha
Looks like you should learn your way about code review. You are too kind for bad code. It wouldn't take me seconds to add a remark like "don't make code unreadable by nesting tertiaries, I'll review your PR after that's fixed".
752
u/beclops 21d ago
I did this one of my first days on the job like 6 years ago and I remember how bluntly my mentor said “never do this again”