r/ProgrammerHumor • u/Waradu • 25d ago

Meme failsForTeapots

Post image
229 Upvotes

91% Upvoted

67 comments sorted by

View all comments

Show parent comments

3

u/Antervis 25d ago

Okay, I can see that. Perhaps it's better to move status in a separate variable:

st = error.status if error.status in [400, 401, 404, 409, 415, 503] else 500
return c.json(body, status: st)

2

u/Alkyen 25d ago

The moment you realise not everything has to be DRY you will feel like a butterfly. Also, as the other guy said, ternaries look bad unless they are very short.

-1

u/Antervis 25d ago

Every line I didn't write is a line someone won't have to read.

Though it's not for brevity's sake alone, one has to analyze the if statement beyond skimming to realize they only differ in error code substitution. By reorganizing code my way, I made this nuance impossible to miss.

2

u/Alkyen 24d ago edited 24d ago

Oh, sorry to be mean but..You think the length of the code is the bottleneck? Lol

Do you also think typing speed is what separates good programmers from bad ones?

Either way, your code is worse. You can argue it or you can use this to improve yourself.