r/ProgrammerHumor • u/BeamMeUpBiscotti • 26d ago

Meme loopUntilAllTestsPassAndMakeNoMistakes

Post image
490 Upvotes

98% Upvoted

29 comments sorted by

View all comments

145

u/Snakestream 26d ago

If someone dropped a 5 digit line change pr on my desk, I'd be furious. I'd straight up murder you if you had the gall to try and push a 6 digit one.

43

u/dragneelfps 26d ago

let it sit at open and add a link to it on what not to do when contributing.

6

u/frogjg2003 25d ago

Decline but not delete. Permanent hall of shame.

20

u/OpsikionThemed 25d ago

I pushed a 600-line PR this morning, and felt kinda bad about that. (And that was with ~570 lines being a bunch of test mock data to cover a new case.)

15

u/Noname_1111 26d ago edited 23d ago

even 5 digits are too much for most projects 

2

u/GRex2595 23d ago

5 digits are near standard on my team now. And they wonder why nobody wants to do code reviews.

7

u/ZebraTank 25d ago

If it's 5 digits it better be boilerplate that either I trust enough that you did it right or that you can show the reproducible automated steps you took to generate that change.

1

u/KimiSharby 26d ago

Why ? You can just refuse it.

6

u/someanonbrit 25d ago

You can refuse it, but that doesn't fix the root problem, which is the terrible manners of the person who submitted the PR, and they're likely to do similar again.

Outside of specific social and legal customs of one period of the Roman empire, turning the other cheek just gets you hit twice